Git Product home page Git Product logo

Comments (6)

tonistiigi avatar tonistiigi commented on June 12, 2024

duplicate of #4482 I think

from buildkit.

fenollp avatar fenollp commented on June 12, 2024

Ah I missed that one sorry.

Could --checksum=.. have some weight in the "Is this legacy behavior due to security reasons?" department?

from buildkit.

tonistiigi avatar tonistiigi commented on June 12, 2024

No, --checksum is much newer feature than ADD <url>

from buildkit.

fenollp avatar fenollp commented on June 12, 2024

Sorry, I mean can --checksum help solve the (potential?) security issue of extracting some URL?

from buildkit.

tonistiigi avatar tonistiigi commented on June 12, 2024

I don't get what you mean. --checksum can work with or without unpacking. Verification happens on download of the URL.

from buildkit.

fenollp avatar fenollp commented on June 12, 2024

Sorry again!
I insinuated that, if the reason for legacy code to disallow extracting URLs was because with time the downloaded content can change to something else, the domain point to another host, an attacker does anything, .... then, now that we "recently" introduced --checksum=digest, then today we have a solution to that attack surface.

Thus making the argument that extraction should now be allowed but only for --checksumed URLs and only when a to-be-introduced flag is used.

Would you guys agree with that view?

from buildkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.