Comments (3)
differentiating between a tag or a branch (and a non-full commit)
FWIW, the simpler answer to this is to use full/explicit refs instead of abbreviated ones (refs/tags/xxx
vs refs/heads/xxx
or even GitHub's fancy refs/pull/xxx/head
refs for test-building pull requests, for example).
(IMO [not a buildkit maintainer], it would be weird to invent buildkit-specific syntax sugar for these refs such that tag=
gets translated to refs/tags/
and branch=
to refs/heads/
)
from buildkit.
tag and branch cannot be used together
As @tianon said this can already be done with setting full ref. Additionally, I think builds from refs like refs/pull/xxx/head
are very useful, so if we added a new syntax that capability would need to be kept. Even with CSV I would prefer ref=..
instead of branch=,tag=
.
commit can be a short commit hash instead of a full one
This looks like too much sugar to me. You can't do docker pull alpine@sha256:partialhex
.
renovate can work with branch or tag (git tags are as mutable as branches) and commit, as with images
Don't exactly get what case you have in mind here.
Downsides:
- CSV is quite cumbersome to read and write.
##
looks weird as well.
Potential opportunities with CSV format:
- Ref and commit can't be used together atm in a URL. That is important use case for replaying a historic build from a git ref, with a pin to a specific commit (this info is provided by provenance attestation). Another question is what
ref=,commit=
combination actually means, and I guess it should just ignore/trust the ref in that case and use the commit. Ref might still be visible as current branch in.git
. This is similar to how tag is ignored on container image refs if digest is present. - Keeping/discarding
.git
directory could be controlled by a property that is more flexible solution than currentBUILDKIT_CONTEXT_KEEP_GIT_DIR
build arg. - If keeping
.git
then another property could be used to control the depth of the cloned commit chain. - In #4646 , subdir component can potentially split into subdir + filter components.
from buildkit.
Agreeing on all points.
Note about renovate
(and the majority of my motivation here): is to have a ref=..,commit=..
pair for git repos as we have $IMG:..@sha256:..
for images. That is, a constraint + a lock. Tooling can use this to auto-upgrade code.
I guess it should just ignore/trust the ref in that case
I understand this is today's behavior WRT image tags. I would argue that some kind of check that ensures that the given digest exists in/among/as the given constraint (at least once, some time in the past). e.g. make sure $commit exists on $branch.
I remember a beforetime when GitHub would be fine showing commits from some fork as commits of the upstream, trusted repo.
from buildkit.
Related Issues (20)
- can't add CA cert for gha remotecache?
- Inconsistencies in RUN mount options parsing/handling HOT 1
- dockerfile: Add integration test for ARG with empty value and default
- [v0.13] It seems that "registry.insecure=true" doesn't work. HOT 7
- buildkit remote cache fails if manifest is larger than 1MB
- Windows buildkit: copy context error HOT 6
- Proposal: lint disable controls HOT 4
- windows differ is not implemented HOT 1
- `FROM --platform=$BUILDPLATFORM a as b` not overriding `TARGETPLATFORM` for multi-stage builds HOT 7
- `checksum`ing "local files" for remote builder contexts HOT 2
- Docker buildkit stuck with high CPU and unresponsive HOT 7
- COPY argument `--chmod` not working on directories
- dockerfile:1.7-labs: COPY fails where there exists broken symbolic link and --exclude is specified
- ResourceExhausted: grpc: received message larger than max (_ vs. 4194304) HOT 1
- COPY creates file with incorrect contents HOT 2
- Th
- Getting error when trying to build multiarch images with an argoworkflow - failed to solve: process "/dev/.buildkit_qemu_emulator HOT 2
- Network Issue with using RUN in dockerfile in Windows Builds HOT 11
- Debug upload to gha cache HOT 1
- Buildkit export getting delayed on exporting layers stage HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildkit.