Git Product home page Git Product logo

Comments (5)

danielkcz avatar danielkcz commented on May 18, 2024

Yea, I noticed that as well and it's a kinda main reason why I am mostly using useObserver whenever I can. In other cases, I just have a named function.

export default observer(function Item() {
  return <div />
})

Either way, these are just workarounds for sure. Personally, I haven't use Proxy for anything yet. There is an obvious problem it's not supported in IE11 so it would need some ponyfill. And it shouldn't be used in a production code.

Um, could you try to make some preliminary PR? Ideally with tests. I am definitely preoccupied for next weeks.

from mobx-react-lite.

xaviergonz avatar xaviergonz commented on May 18, 2024

There's always defineProperty with a getter and setter, which is like the poor's man proxy

from mobx-react-lite.

xaviergonz avatar xaviergonz commented on May 18, 2024

Either way though, since Reaction takes a plain string any name change after the fact would require a reaction destruction and re-creation, so maybe it could be added as an option to observer instead (displayName?: string)?

const Item = observer(() => <div />, { displayName: "Item" })

from mobx-react-lite.

danielkcz avatar danielkcz commented on May 18, 2024

That's a really ugly escape hatch :) I would rather avoid things that cannot be compiled away from a production build. I cannot help it but using named function instead of anonymous one comes to be as the best solution really.

from mobx-react-lite.

danielkcz avatar danielkcz commented on May 18, 2024

Another approach I just spotted in some chatroom. This way the observer grabs the name correctly.

const Item = () => <div />

export default observer(Item)

I've decided to reconsider this whole thing. It's not really a bug. It's coming from the way JS works. Some sufficient approaches have been described, for now, so I am closing.

from mobx-react-lite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.