Enable conjugation about quaternion HOT 6 CLOSED

I don't think I'll be able to affect this behavior, because it's hard-wired to call the complex conjugate function. The only thing that does work is numpy.conjugate, which should be sufficient, as long as the user knows not to use q.conjugate().

from quaternion.

I've sent an upstream patch for this issue as numpy/numpy#9003.

from quaternion.

Thank you! I can verify that your patch does indeed fix this problem. I'll mention that on the numpy PR.

My statements above were not really clear enough. In particular, it wasn't clear that the problem applies to arrays of quaternions rather than individual quaternions. So I'll just write a simple test that shows the problem

import numpy as np
import quaternion

q = np.array([np.quaternion(1,2,3,4), np.quaternion(5,6,7,8)])
q_c = np.array([np.quaternion(1,-2,-3,-4), np.quaternion(5,-6,-7,-8)])

assert np.array_equal(q.conjugate(), q_c)

from quaternion.

With the merge of numpy/numpy#9061, this is fixed upstream (and as of numpy 1.13).

from quaternion.

Thanks for all that work! I'll keep an eye out for the 1.13 release and rebuild the conda packages. Meanwhile, I'll leave this open as a reminder to myself to do that.

from quaternion.

Actually, I just realized that the 1.13 release hasn't come out on conda yet, so I'll leave this open still.

from quaternion.