Comments (7)
sandro-heitz
commented on June 24, 2024
1
Hello,
I could create a pull request during the next weekend.
Sandro
By the way, the mountain looks impressive and much lonier than the alps!
…On Mon, Jun 11, 2018 at 7:06 PM Mateusz Wijas ***@***.***> wrote:
Nope that makes sense and I didnt think of that case, thanks for the
explanation
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOLJa4ouh-Ajc_QsNASCZD5JAtGekWm5ks5t7qORgaJpZM4UhmsR>
.
--
t.h.e. Software GmbH
Speyerer Strasse 4
D-76287 Rheinstetten
Tel. +49-7242-933779
contact@the-software dot de
www.the-software.de
Geschäftsführer: Dipl.-Ing. Sandro Heitz
Handelsregisternummer: HRB 107759, Amtsgericht Mannheim
USt.-IdNr.: DE 186773284
from react-password-strength.
mmw
commented on June 24, 2024
I never implemented something like this because generally we dont want to encourage limiting password length as a pattern to follow. What is the use case for this feature? The only thing I could think of is if you are implementing with a legacy system that imposed password length restrictions.
I suppose having this does make it feature complete. I'll try to find some time to implement. Feel free to raise a PR if you have the time/interest to do this.
Thanks for using the tool, glad you found it useful 👍
from react-password-strength.
sandro-heitz
commented on June 24, 2024
Hello,
very long passwords can be used to create a kind of denial of service
attack because the salting is very expensive. You might answer now, that
you have to check this on the server and it is done (don't trust the
browser). But it is important, that a real user gets immediate and correct
response on typing his password in the browser and not after submitting the
form to the server.
But it's ok, if you do not want to implement something like this. It can
live with the local workaround.
Sandro
…On Mon, Jun 11, 2018 at 6:29 PM Mateusz Wijas ***@***.***> wrote:
I never implemented something like this because generally we dont want to
encourage limiting password length as a pattern to follow. What is the use
case for this feature? The only thing I could think of is if you are
implementing with a legacy system that imposed password length restrictions.
I suppose having this does make it feature complete. I'll try to find some
time to implement. Feel free to raise a PR if you have the time/interest to
do this.
Thanks for using the tool, glad you found it useful 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOLJayvaJfSic5dgZvrGWh9yLNCKZo-8ks5t7pr-gaJpZM4UhmsR>
.
--
t.h.e. Software GmbH
Speyerer Strasse 4
D-76287 Rheinstetten
Tel. +49-7242-933779
contact@the-software dot de
www.the-software.de
Geschäftsführer: Dipl.-Ing. Sandro Heitz
Handelsregisternummer: HRB 107759, Amtsgericht Mannheim
USt.-IdNr.: DE 186773284
from react-password-strength.
mmw
commented on June 24, 2024
Nope that makes sense and I didnt think of that case, thanks for the explanation
from react-password-strength.
mmw
commented on June 24, 2024
@sandro-heitz I had some time to implement a fix here. Wondering why wouldnt you just pass maxLength through inputProps to achieve the desired result?
from react-password-strength.
sandro-heitz
commented on June 24, 2024
I will have a look in a few days. I'm a bit busy at the moment.
from react-password-strength.
sandro-heitz
commented on June 24, 2024
maxLengh is an adequate solution. Thank you ...
from react-password-strength.
Related Issues (20)
- How to access ref to call clear HOT 5
- Allow passing additional dictionary words HOT 1
- Expose zxcvbn feedback object to result object through changeCallback HOT 3
- Support for material-ui HOT 3
- Support React 16 HOT 1
- Unable to set value - for multi step form HOT 7
- ReferenceError: self is not defined HOT 8
- The component is extremely slow on 50+ symbols HOT 1
- Unresolved module in build HOT 1
- Don't provide custom CSS HOT 9
- onChange not working HOT 1
- Placeholder not being displayed HOT 1
- bundle very large HOT 4
- Unable to resolve module HOT 2
- Cannot pull latest 2.4.0 HOT 2
- Ability to add custom rules HOT 1
- Switch to asdfgh
- Override colors
- Support React 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-password-strength.