Git Product home page Git Product logo

Comments (2)

germolinal avatar germolinal commented on July 22, 2024

PD: I asked Greg Ward—developer of Radiance—and he told me to check my sampling and pdf values for checking the Montecarlo integration. I integrated a hemisphere of value 1, and found the expected answer of Pi; and by integrating a unit overcast sky (i.e., L=(1. + 2. * cos(theta))/3) gives me the expected Pi * 7/9. I guess the error must come from elsewhere.

I'll keep digging!

from pbrt-v4.

germolinal avatar germolinal commented on July 22, 2024

All right. I have solved this issue. As it happens, my implementation was correct apparently, but some of the Radiance parameters I was using prevented it from accounting for the last bunch of—low-energy—bounces. This was particularly noticeable in one of my scenes, which had a 90% reflective surface (to take into account these things)... I guess there is a lot of value in my new implementation, based on your work: it has less and more predictable parameters.

from pbrt-v4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.