Comments (2)
mmistakes
commented on August 26, 2024
1
I think this is something best left up to the theme user since it can be a bit heavy handed. I do this exact thing with my personal site.
A lot of people using my themes are not devs and inlining CSS adds one more hurdle for them... as if using Jekyll, Liquid, Sass, JavaScript, etc. wasn't enough to learn.
I'm trying to treat these themes as starting points with sensible defaults. It's up the user to decide how far they want to take things as far as web perf and the like are concerned.
from jekyll-theme-skinny-bones.
wilsonmar
commented on August 26, 2024
I think that this particular enhancement is relevant to all themes ... to all sites really.
Would you like me to send you a PR after I make the change and test it?
I'm thinking it's a matter of moving main.css as an include rather than as a download link.
from jekyll-theme-skinny-bones.
Related Issues (20)
- Adding tags to archive
- Can't build from master : invalid date in front matter? HOT 1
- Accessibility errors found in your template
- custom 404 HOT 2
- disable page open animation HOT 4
- Teaser images in sharing HOT 2
- Content below post-grid sucked into grid HOT 2
- Site not building on GitHub pages HOT 10
- Pagination? HOT 1
- May support markdown tilde '~' ? HOT 2
- Typo in "Site Setup"
- could I change the locales dynamicly on the page? HOT 2
- Title bar will line break with more than 4 -5 titles HOT 4
- https: problem with certificate HOT 2
- error GitHub Pages: docs/css/main.scss has an error on line 10 HOT 2
- Disqus does not load HOT 5
- More authors HOT 1
- share-this.html gives page build error with numeric page titles
- Page build failed with gh-pages HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jekyll-theme-skinny-bones.