Git Product home page Git Product logo

Comments (5)

mmistakes avatar mmistakes commented on June 7, 2024 1

In progress #48

from jekyll-theme-basically-basic.

mmistakes avatar mmistakes commented on June 7, 2024

I think this is a good idea and something I'd be interested in adding. I'd like to give it some thought on how I'd do this as I'd like to have a search fallback option that is 100% GitHub Pages compatible. Just to cover those who can't install Jekyll plugins or don't want to added complexity of using something like Travis CI to get around GH Pages 3rd party plugin limitations.

My other theme Minimal Mistakes recently added search support for Lunr.js, so I'm thinking that would be a good fallback. Just need to think about how I want the config setup to look like for the user.

The MM theme could also benefit from adding support for jekyll-algolia, especially since it's way more popular than this theme 😉.

I'll work on a proof of concept PR and ping you @pixelastic if I hit any issues.

from jekyll-theme-basically-basic.

pixelastic avatar pixelastic commented on June 7, 2024

Awesome. I didn't check that MM had a search page already 🙄. That makes it an even better candidate.

Lunr would make a very good fallback for people that don't want to setup a Travis account for GitHub pages. It will be less efficient in terms of typo-tolerance and amount of data searchable, but will still give great results.

Let me know how if you have any questions and I'd be happy to help any way I can.

from jekyll-theme-basically-basic.

mmistakes avatar mmistakes commented on June 7, 2024

Merged in #48

from jekyll-theme-basically-basic.

mmistakes avatar mmistakes commented on June 7, 2024

Basically Basic demo site with Algolia search enabled - https://mmistakes.github.io/jekyll-theme-basically-basic-algolia-search/

from jekyll-theme-basically-basic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.