Git Product home page Git Product logo

Comments (8)

mmazzarolo avatar mmazzarolo commented on July 3, 2024 1

My bad, I didn't wrote it correctly, I simply wanted to know if currently the Date gets updated correctly on Android too (it's important having platform parity!).
Thank you @bitsal, you should expect a next release soon 👍

from react-native-modal-datetime-picker.

mmazzarolo avatar mmazzarolo commented on July 3, 2024

I recently merged PR #18 that should address you issue.
I haven't pushed it to NPM yet, would you mind trying it?
The best way to try it is pulling the library from the Master branch.
Alternatively, simply copy-paste the content of this file in your node_modules/react-native-modal-datetime-picker/src/CustomDatePickerIOS/index.js.
Then just reset the server npm run start -- --reset-cache and fire up your emulator.

P.S.: The interested line is this one

from react-native-modal-datetime-picker.

bitsal avatar bitsal commented on July 3, 2024

@mmazzarolo thank you, I can prove that your fix works. Looking forward to new version.

from react-native-modal-datetime-picker.

mmazzarolo avatar mmazzarolo commented on July 3, 2024

Cool! Can you also give it a try at the Android version? If it work correctly I'll release the version this evening :)

from react-native-modal-datetime-picker.

bitsal avatar bitsal commented on July 3, 2024

I see there is only this fix from 3.0.1 version. I don't think it can break Android somehow due to you have different components for iOS and Android.

BTW, I've checked it on Android. It seems to work as expected.

from react-native-modal-datetime-picker.

bitsal avatar bitsal commented on July 3, 2024

Oh, I got it. Be calm the issue was only on iOS side, at least in our app.

from react-native-modal-datetime-picker.

mmazzarolo avatar mmazzarolo commented on July 3, 2024

@bitsal landed in release 4.0.0

from react-native-modal-datetime-picker.

temitope avatar temitope commented on July 3, 2024

thanks so much for this fix guys!

from react-native-modal-datetime-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.