Git Product home page Git Product logo

Comments (26)

heisenbuug avatar heisenbuug commented on June 3, 2024 2

@deeplearningera this is almost done, you can pick any new type of conversion by going through the issue.
If you have any doubts regarding how to implement you can ping me anytime...

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024 1

Hey @heisenbuug, please feel to pursue it, it's still open.

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024 1

Looks good to me, maybe in the PR we could wrap it in a class and have a member function called CSVToXML or some better name.

from models.

heisenbuug avatar heisenbuug commented on June 3, 2024 1
  • I wrapped it up in a class, I named the main function as csvxmlHelper() which is private.
  • I made a public function convert, what I have in my mind is we can pass two parameters to this convert function(apart from path) and based on these parameters(which will be input file type and output file type) it will decide which helper fucntion to call.
    convert(path, csv, xml) -> this will convert csv file to xml format
  • I think this should be better, for now I am keeping the convert function simple. As soon as I add other conversion types I will modify it accordingly, sounds good?

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024 1

Sure, makes sense.

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024 1

Hey @Rajat-Rao-R, Yes its open. @heisenbuug opened a promising PR #33 for this issue. Maybe you can build upon that / or take inspiration from it.

from models.

mlpack-bot avatar mlpack-bot commented on June 3, 2024

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024

Keep Open.

from models.

heisenbuug avatar heisenbuug commented on June 3, 2024

Hey @kartikdutt18 I want to start working on this issue, I hope it's still open...

from models.

heisenbuug avatar heisenbuug commented on June 3, 2024

Can you just get me the link for that roboflow.ai's convert function?

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024

Sure, You can select the convert option in the link to see it's functionalities.

from models.

heisenbuug avatar heisenbuug commented on June 3, 2024

@kartikdutt18 we need something like this https://github.com/xhallix/PyCsv2Xml right? But also for all the specified formats.

from models.

heisenbuug avatar heisenbuug commented on June 3, 2024

I will start working on converting csv to xml.
I have some doubt

  • Where exactly do you wanna put this convert function?

  • I will have to use a xml parser for this task as well, I was thinking about TinyXML Do you have anything specific in mind if not this?

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024

Where exactly do you wanna put this convert function?

I think we could add this to the utility folder or maybe create a new directory.

I will have to use a xml parser for this task as well, I was thinking about TinyXML Do you have anything specific in mind if not this?

We already use boost xml parser, Refer LoadObjectDetectionDataLoader in Dataloader class.

from models.

heisenbuug avatar heisenbuug commented on June 3, 2024
  • I am done with the main logic for converting cvs to xml files.
  • This is the link to the code and I have also included example input and output in the same repo.
  • Some things are still remaining, for example when we have same file names its creating multiple xml files rather than appending in the same one, I will handle that and other cases.

For now I just need a check on the logic.

from models.

Rajat-Rao-R avatar Rajat-Rao-R commented on June 3, 2024

Hey @kartikdutt18 wanted to start from somewhere , found this . Is it still open ?

from models.

Rajat-Rao-R avatar Rajat-Rao-R commented on June 3, 2024

@kartikdutt18 I have some doubt
You were referring to roboflow https://roboflow.com/convert/coco-json-to-pascal-voc-xml , here the conversions are model specific but the conversion that heisenbuug did is csv to xml only
So do we need to be specific or we just need conversion mechanism .

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024

I think we should be able to accommodate both. We can have static function that simply converts data from one format to other. Other than that, we can model / dataset specific conversion. This can be done by having separate functions or we can pass two strings and store a map that internally calls the correct function. Let me know what you think.

from models.

Rajat-Rao-R avatar Rajat-Rao-R commented on June 3, 2024

Yeah this will be better , because it will keep things clean and we can accommodate different models smoothly then .

from models.

deeplearningera avatar deeplearningera commented on June 3, 2024

@kartikdutt18 Can I also work upon?

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024

Sure. Feel free to pursue this.

from models.

deeplearningera avatar deeplearningera commented on June 3, 2024

Sure. Feel free to pursue this.

Thanks!

I have also commented here, please acknowledge it.

from models.

kartikdutt18 avatar kartikdutt18 commented on June 3, 2024

You need to ask @heisenbuug for that. If he gets a chance, he will reply to you on the thread.

from models.

deeplearningera avatar deeplearningera commented on June 3, 2024

Okay

from models.

deeplearningera avatar deeplearningera commented on June 3, 2024

You need to ask @heisenbuug for that. If he gets a chance, he will reply to you on the thread.

Tell me one thing, if he acknowledges and I make appropriate changes, then will it be considered as a PR?

Actually I am new to open source.

from models.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.