call about gsm-shield-arduino HOT 15 CLOSED

On svn-69 this function is:

void CallGSM::Call(char *number_string)
{
  if (CLS_FREE != gsm.GetCommLineStatus()) return;
  gsm.SetCommLineStatus(CLS_ATCMD);
  // ATDxxxxxx;<CR>
  gsm.SimpleWrite("ATD");
  gsm.SimpleWrite(number_string);    
  gsm.SimpleWrite(";\r");
  // 10 sec. for initial comm tmout
  // 50 msec. for inter character timeout
  gsm.WaitResp(10000, 50);
  gsm.SetCommLineStatus(CLS_FREE);
}

No SimpleWriteWOln, but last '\r' seems odd.

Why? You tested the command on the real SIM900?

[deleted comment]

The difference between SimpleWriteWOln and SimpleWrite is the \r at the end ;) 
the first is without so the command is ATD+3933282343;

void SIMCOM900::SimpleWrite(char *comm)

{

    _cell.println(comm);

}



void SIMCOM900::SimpleWrite(const char *comm)

{

    _cell.println(comm);

}



void SIMCOM900::SimpleWrite(int comm)

{

    _cell.println(comm);

}



void SIMCOM900::SimpleWriteWOln(char *comm)

{

    _cell.print(comm);

}



http://arduino.cc/en/Serial/Println
Description
Prints data to the serial port as human-readable ASCII text followed by a 
carriage return character (ASCII 13, or '\r') AND A NEWLINE CHARACTER (ASCII 
10, or '\n').

[deleted comment]

You send this: ATD/r/n+3933282343/r/n;/r/r/n

From sniffer

Yes... but pay attention that the last one is _cell.print(comm); and not 
_cell.println(comm)
it is WithOut ln at the end ;)

Which code is correct?

1)
 gsm.SimpleWrite("ATD");
 gsm.SimpleWrite(number_string);    
 gsm.SimpleWrite(";\r");

2)
 gsm.SimpleWriteWOln("ATD");
 gsm.SimpleWriteWOln(number_string);    
 gsm.SimpleWrite(";");

Cool the sniffer program.. Which is its name? :) 
OK I've checked...the solution is that the correct one is 
 gsm.SimpleWriteWOln("ATD");
 gsm.SimpleWriteWOln(number_string);    
 gsm.SimpleWrite(";");
But if you ask me why in the last version there is the first..I don't know. 
Sorry, I didn't understood your right suggestion in the first comment!
Thank you :)

> Which is its name? :) 
http://www.saleae.com/Logic

ps/ check all code, for example:

  gsm.SimpleWrite("GET ");

  gsm.SimpleWrite(path);

  gsm.SimpleWrite(" HTTP/1.0\nHost: ");

  gsm.SimpleWrite(server);

  gsm.SimpleWrite("\n");

  gsm.SimpleWrite("User-Agent: Arduino");

  gsm.SimpleWrite("\n\n");

  gsm.SimpleWrite(end_c);

and etc...

pps/ see attachment for email, HTTP, FTP for SIM900

Thank you! 
For the PS (get method) it works, but now I'm going to check all the code.
I also fixed another point where there was the same mistake.
For PPS: For now I want to improve the stability and try to fix all bugs before 
start new implementations (I haven't a lot of time in this months). But if you 
want to try or just to publish some your functions, I can add you at the 
project. Let me know :)

This issue section is not longer supported.
Please check the support page www.gsmlib.org