Comments (4)
I tacked on a quick fix with #1058
from mlx.
@jagrit06 this seems that we are overflowing an integer index into the output as it starts to break in the 2B range. INT_MAX is on the small side for the largest output we can support though.
Anything we can do to support larger sizes?
If not, we should put some throws in the ops as these are sneaky to debug.
from mlx.
This particular case is simple since what happens is when we try to compute auto batch_size_out = out.size() / (M *N);
, the int M and N multiple to overflow and then the batch_size_out comes out to 0
The simple fix here is do that in size_t and I can make a couple other changes to make sure we can handle the large shapes
The only things I'm wondering about is if batch_size_out >= UINT32_MAX, then we will need to launch multiple matmul kernels since the grid dims can only be uint
from mlx.
The only things I'm wondering about is if batch_size_out >= UINT32_MAX, then we will need to launch multiple matmul kernels since the grid dims can only be uint
That seems like a much more rare case.
from mlx.
Related Issues (20)
- [Feature] Multi-Machine Support for Distributed Inference HOT 4
- [BUG] mlx_lm issue with Phi-3 fine tuned model: adding and repeating weird tokens HOT 2
- [FEATURE] in keras LayerNorm by default is apply to last dimension only HOT 9
- [BUG] in-place updating of array slice unexpectedly fails due to broadcasting problem HOT 2
- [BUG] broadcast of scalar array in last dimension fails after #1035
- [BUG] Unable to install mlx on MacbookPro M3Pro with MacOS 14.4.1 HOT 1
- [FEATURE] how to return mlx intermediate layer output similarly to Keras HOT 2
- [BUG] cannot replicate a keras model into mlx when I reuse keras pretrained weights
- [BUG] EOS terminator for mlx_lm generate function HOT 1
- [BUG] libc++abi crash when using recurrent layer and transformer HOT 2
- [Feature] arctan2 HOT 3
- [BUG] arithmetic operations with numpy arrays are not commutative HOT 3
- [Feature] KANs HOT 1
- No module named 'mlx.core'; 'mlx' is not a package HOT 2
- 0.12.2 release was not completed HOT 8
- [FEATURE REQUEST] mx.grad doesn't alias argnums and argnames HOT 5
- [BUG]
- [BUG] `np.ndarray` of bfloat16 using ml_dtypes is being interpreted as complex64
- [BUG] mlx crashes with msg - uncaught exception of type std::invalid_argument: [Scatter::eval_gpu] Does not support int64 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mlx.