Git Product home page Git Product logo

Comments (4)

bill88t avatar bill88t commented on August 22, 2024 1

Sorry for the late response. Indeed with this patch, it built and ran successfully.
I opened it and tested it briefly, nothing seems amiss.

from extension-manager.

oscfdezdz avatar oscfdezdz commented on August 22, 2024

Thanks for the heads up! Does the following patch together with your patches fix it?

From 1fe44e88a343d347f9703a4ee1086bbc0ebb50b7 Mon Sep 17 00:00:00 2001
From: oscfdezdz <[email protected]>
Date: Fri, 17 May 2024 01:20:57 +0200
Subject: [PATCH] Fix some warnings

---
 src/exm-detail-view.c | 4 ++--
 src/exm-window.c      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/exm-detail-view.c b/src/exm-detail-view.c
index f91bb1a..072513e 100644
--- a/src/exm-detail-view.c
+++ b/src/exm-detail-view.c
@@ -595,8 +595,8 @@ exm_detail_view_class_init (ExmDetailViewClass *klass)
     gtk_widget_class_bind_template_callback (widget_class, breakpoint_unapply_cb);
     gtk_widget_class_bind_template_callback (widget_class, screenshot_view_cb);
 
-    gtk_widget_class_install_action (widget_class, "detail.open-extensions", NULL, open_link);
-    gtk_widget_class_install_action (widget_class, "detail.open-homepage", NULL, open_link);
+    gtk_widget_class_install_action (widget_class, "detail.open-extensions", NULL, (GtkWidgetActionActivateFunc) open_link);
+    gtk_widget_class_install_action (widget_class, "detail.open-homepage", NULL, (GtkWidgetActionActivateFunc) open_link);
 }
 
 static void
diff --git a/src/exm-window.c b/src/exm-window.c
index 472c199..ade4ffd 100644
--- a/src/exm-window.c
+++ b/src/exm-window.c
@@ -404,7 +404,7 @@ exm_window_init (ExmWindow *self)
     }
 
     self->manager = exm_manager_new ();
-    g_signal_connect (self->manager, "error-occurred", on_error, self);
+    g_signal_connect (self->manager, "error-occurred", G_CALLBACK (on_error), self);
 
     g_object_set (self->installed_page, "manager", self->manager, NULL);
     g_object_set (self->browse_page, "manager", self->manager, NULL);
-- 
2.45.0


from extension-manager.

oscfdezdz avatar oscfdezdz commented on August 22, 2024

Great, I'll open a PR with it and review yours.

from extension-manager.

oscfdezdz avatar oscfdezdz commented on August 22, 2024

Everything seems to work correctly in the Flatpak stable runtime as well. I'll close the issue if there are no more problems. Again, thanks for the report!

from extension-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.