Git Product home page Git Product logo

Comments (7)

mjackson avatar mjackson commented on June 5, 2024

Hi @trevordmiller – thanks for the bug report!

Under the hood we're just using deepEqual to check for equality, so we should probably open a bug report on https://github.com/substack/node-deep-equal.

from expect.

mjackson avatar mjackson commented on June 5, 2024

BTW, please be sure to reference this issue when you do so we know when we should upgrade. Thanks!

from expect.

mjackson avatar mjackson commented on June 5, 2024

Oh, wait. I just re-read your original post.

I would actually expect that test to pass. toEqual checks for equal values, but they don't have to be the same object. Use toBe for that.

from expect.

rstacruz avatar rstacruz commented on June 5, 2024

I don't think that test should pass:

var a = new Set('a');
var b = new Set('b');

any way you look at it, equivalence or equality, they should be false. They're 2 different objects with 2 different values.

from expect.

mjackson avatar mjackson commented on June 5, 2024

Blah, sorry. You guys are right. I need to read more closely next time :P

Let's definitely open an issue on deep-equal and follow up there.

from expect.

mjackson avatar mjackson commented on June 5, 2024

Released in v 1.13.1

from expect.

trevordmiller avatar trevordmiller commented on June 5, 2024

@mjackson Works great now! Thank you so much.

from expect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.