Git Product home page Git Product logo

Comments (4)

mity avatar mity commented on May 26, 2024

That's great.

It might be good to add it directly into the cutest repo, if it is adapted a little bit (e.g. to make relative/local references to cutest.h).

Just few minor things I noticed:

Some code lines in the examples differ, likely unintentionally. E.g.:

    { "PI accurate to 7 digits", pi_accurate_to_7_digits },

vs.

    { "PI accurate to 7 digits?", pi_accurate_to_7_digits },

(See the question mark).

Another example:

    TEST_CHECK(PI == 3.1415927);

vs.

    TEST_CHECK(PI == 3.1415927f);

(See the f suffix).

Also I am unsure if tutorial should promote unit test names with spaces: When specifying such unit test name on command line then requires escaping or quotes.

Last but not least, the implementation of pi_accurate_to_7_digits() is somewhat problematic and fragile: It does not work if PI is defined with better precision then the 7 digits. So it should either do some rounding of PI to the expected precision, or it should check that PI is in the range [3.1415927f - 0.,5e-7; 3.1415927f + 0.5e-7) instead of equality.

from acutest.

irontribe avatar irontribe commented on May 26, 2024

Thanks kindly! I'll fix all that stuff. One problem--I don't know which unit test names had spaces? I absolutely didn't want that to happen but can't find it anywhere.

from acutest.

mity avatar mity commented on May 26, 2024

"PI accurate to 7 digits"

from acutest.

mity avatar mity commented on May 26, 2024

Closing as I cannot see any progress.

If you eventually do it, feel free to ping me or reopen this. (Ideal would be creating pull request for it.)

from acutest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.