Deion It seems to be pretty trivial to trick the parser into

`and`, `or`, `not`, `is`, and `in` are not reserved words. about minijinja HOT 3 CLOSED

mitsuhiko commented on May 22, 2024

`and`, `or`, `not`, `is`, and `in` are not reserved words.

from minijinja.

Comments (3)

valarauca commented on May 22, 2024

Appears to be only and and or. I'll try to write up a patch.

from minijinja.

mitsuhiko commented on May 22, 2024

I can imagine there being bugs but I am actually not able to reproduce. The following template:

{{ '{{ a }}' == 'a' and ( '{{ a }}' != 'b' or '{{ a }}' != 'c' ) }}

Produces the following AST:

Ok(
    Template {
        children: [
            EmitExpr {
                expr: BinOp {
                    op: ScAnd,
                    left: BinOp {
                        op: Eq,
                        left: Const {
                            value: "{{ a }}",
                        } @ 1:3-1:12,
                        right: Const {
                            value: "a",
                        } @ 1:16-1:19,
                    } @ 1:0-1:19,
                    right: BinOp {
                        op: ScOr,
                        left: BinOp {
                            op: Ne,
                            left: Const {
                                value: "{{ a }}",
                            } @ 1:26-1:35,
                            right: Const {
                                value: "b",
                            } @ 1:39-1:42,
                        } @ 1:24-1:42,
                        right: BinOp {
                            op: Ne,
                            left: Const {
                                value: "{{ a }}",
                            } @ 1:46-1:55,
                            right: Const {
                                value: "c",
                            } @ 1:59-1:62,
                        } @ 1:43-1:62,
                    } @ 1:24-1:62,
                } @ 1:0-1:64,
            } @ 1:0-1:64,
        ],
    } @ 0:0-1:67,
)

Which seems fine? Can you provide a minimal test case that shows this behavior?

from minijinja.

mitsuhiko commented on May 22, 2024

I'm unable to reproduce this. Jinja never had keywords and syntax wise it should not be necessary to enforce keywords to avoid ambiguities. The obvious exception is that if you name variables after soft keywords they won't function well in all contexts.

from minijinja.

Recommend Projects