Git Product home page Git Product logo

Comments (12)

Mister-Hope avatar Mister-Hope commented on August 24, 2024

I am not sure if it is a plugin bug. As I said in readme it's just a light wrapper.

How your globs writing should have no effect on this plugin, since it's totally handled by gulp and then in to a pipe. I am just handling your input from the pipe gulp provided, then handle it to sass, and return a transform pipe to let sass compile.

I will test it if I have time.

Did you use other gulp sass plugins before?Did you meet this issue?

from gulp5-sass-plugin.

Mister-Hope avatar Mister-Hope commented on August 24, 2024

image
Sorry I cannot reproduce your issue.

Please give a mininal reproduction repo. And please make sure whether gulp-sourcemap and other plugins related with this issue.

from gulp5-sass-plugin.

Atulin avatar Atulin commented on August 24, 2024

A minimal sample would be Atulin/Ogma repo, gulpfile from the root and files from Ogma3/wwwroot.

I did try it with the plugin this repo is a rewrite of and encountered the same issue. One of the reasons I decided to give your project a shot, actually, hopes of the issue being fixed.

Seeing how both seem to be affected on my end, could it be an issue with Sass? With Gulp itself? Hard to tell, I'd have to consider reporting on all repos that look like they might be involved.

from gulp5-sass-plugin.

Mister-Hope avatar Mister-Hope commented on August 24, 2024

Got it. Actually all the plugin is just a wrapper between gulp and sass.

The glob issue you are talking about, is likely to be a gulp side issue. gulp.src and gulp.watch handle the files it reads or watch, and should give exactly the same result in your two cases. My plugin even do not care about your filea path and contents, I just pass them to sass and resolve the url to make sure they look right in sourcemap.

If your issue do exist after removing gulp-sourcemap and all other plugins,(I suggest you try it) it's likely to be a gulp issue, because if gulp does not have any issue, it should exactly pass the same content to my plugin, and there is no way my plugin or sass can behave differently.

If you found the issue disappear without other plugin, the build time increase may actully from them.

from gulp5-sass-plugin.

Mister-Hope avatar Mister-Hope commented on August 24, 2024

I will close this issue becase I can't do anything now. Feel free to reopen it if you found something new.

from gulp5-sass-plugin.

Atulin avatar Atulin commented on August 24, 2024

What made me think that it's SASS or Gulp-SASS issue, is that I can safely use /**/ with JS and TS without any such issues occurring.

from gulp5-sass-plugin.

Atulin avatar Atulin commented on August 24, 2024

I did remove everything but sass, gulp.dest and gulp.src from the pipeline, and the issue still seems to occur. Looks like I need to raise an issue on the Gulp repo, and not have it resolved lol

from gulp5-sass-plugin.

Atulin avatar Atulin commented on August 24, 2024

Well, supposedly not a Gulp issue: gulpjs/gulp#2549

Time to raise an issue on the SASS repo.

from gulp5-sass-plugin.

Mister-Hope avatar Mister-Hope commented on August 24, 2024

Since, my code works well, a more detailed guess is that some syntax in your code is causing this issue.

I think you should try to split your code to serveral part and try to found out what's causing this. Do not depend on we maintainers. We would prefer a minimal reproduction,(tiny and reproductable)

from gulp5-sass-plugin.

Atulin avatar Atulin commented on August 24, 2024

Here's a minimal sample, ripped straight from my main repo: https://github.com/Atulin/gulp-sample

I did experiment some more, and it does seem like it's the sass() being piped that causes the issue. Watching files itself and throwing them around causes no performance degradation.

from gulp5-sass-plugin.

Atulin avatar Atulin commented on August 24, 2024

Worst case scenario, since the gulpfile is just regular JS, I'll simply write some function to generate those specific globs on demand ¯\_(ツ)_/¯

from gulp5-sass-plugin.

kevinramharak avatar kevinramharak commented on August 24, 2024

@Atulin Your sample does a lot more than just sass. Have you tried it with only sass in the pipeline (no sourcemaps)

from gulp5-sass-plugin.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.