add_tag(event...) is broken! about pymisp HOT 9 CLOSED

Okie, I've pushed a commit that allows for old-style add_tag(event) to be used, without breaking anything (I hope :^) ) - that should work for you :)

from pymisp.

No, this change is expected in order to be consistent with the attributes.

This is the expected way to set a tag on an event: https://github.com/MISP/PyMISP/blob/master/examples/addtag.py#L36

from pymisp.

hm than it is breaking every script that is been using pymisp before, that is somehow odd :/

from pymisp.

It works just fine like

p = PyMISP(..)
e = p.new_event(info="taggo")
p.add_tag(e["Event"], "tlp:white")

It's looking for the id field, which is in Event :)

from pymisp.

so yeah, as @Rafiot's link shows

from pymisp.

yeah but this is just introduced, before it was expecting only the event.
Of course the new way works if you pass the right value, but:

a) it is not easy to understand if the parameter is called "event" but expects event["Event"]
b) breaks all scripts that are around

So I would expect it would expect the same value as before, or explicit ask for the id / uuid
But this mix IMO does make no sense.

from pymisp.

yes, looks good, thank you so much @FloatingGhost

from pymisp.

Is ok, have fun <3

from pymisp.

Well done, thank you very much :)

from pymisp.