Git Product home page Git Product logo

Comments (7)

degcat avatar degcat commented on August 17, 2024

I think html_safe is not good idea for Rails!just like PHP's magic-quotes-gpc
http://cn2.php.net/manual/en/info.configuration.php#ini.magic-quotes-gpc
In PHP world,magic-quotes-gpc disabled default In the current PHP...

We dont need Rails auto escape <%=post.title%>,but <%=h post.title%>is good.Like php world,dont need php escaped with a backslash automatically

from will_paginate.

erikdahlstrand avatar erikdahlstrand commented on August 17, 2024

I can confirm this issue.

from will_paginate.

hakanensari avatar hakanensari commented on August 17, 2024

Can confirm likewise.

As a temporary fix, patched like so:

http://gist.github.com/411770

from will_paginate.

nruth avatar nruth commented on August 17, 2024

given that this feature is a rails 3 backport the rails 3 branch of will-paginate probably has some useful bits and pieces on it.

degcat, this isn't really the right place to discuss it, but I'd say it's needed & whitelisting is good.

from will_paginate.

erikdahlstrand avatar erikdahlstrand commented on August 17, 2024

I'm getting undefined method `paginate' when using rails3 branch. Any ideas?

from will_paginate.

weppos avatar weppos commented on August 17, 2024

I confirm the issue. Appeared with Rails 2.3.7, also available in Rails 2.3.8.
The guilty is the to_html method which doesn't .html_safe the internal html variable.

from will_paginate.

mislav avatar mislav commented on August 17, 2024

duplicate of #19, but thanks for reporting

from will_paginate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.