Git Product home page Git Product logo

Comments (3)

ShMcK avatar ShMcK commented on August 26, 2024

I've done some experimenting with opting out of React Router in Mirror on this project branch. It's not complete, and may not be necessary.

I see a few options now for dealing with the router:

  1. Continue to not support other routers or react-native
  2. Load all router imports through mirrorx/router, a submodule. Then dynamically import it unless an option of noRouter is specified.
  3. Create a separate mirrorx-router package, which can be configured and setup

Both 2 & 3 would create breaking changes, though easy to fix.

from mirror.

llh911001 avatar llh911001 commented on August 26, 2024

I would recommend mirrorx/router as a submodule, what's your opinion?

from mirror.

ShMcK avatar ShMcK commented on August 26, 2024

I think think a submodule makes the most sense.

Also the same design of dva/router.

Dva also recently created multiple different router packages with the 2.0.1 release, including "dva/no-router". I think this is a bit much, as its not really necessary to load another package if you're not using the router.

from mirror.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.