Node.js support about core HOT 6 CLOSED

Thanks for finding those bugs!

What you suggest would be useful, but while we would certainly welcome a node.js package, we could not commit to maintaining it.

Mike

from core.

You are welcome and thank you for your fast response!

It seems to me that there isn't much to do to support Node.js. I am not sure how it will be for npm platform (I didn't it before), but for this repository to support Node.js there is not much to do (as I know in this moment of writing this). I did the following:

• added export of the classes (prototypes) to every file e.g. for fp.js

if (typeof module !== "undefined" && typeof module.exports !== "undefined") {
    module.exports = {
        FP: FP
    };
}

• added a index.js with the following code
  module.exports.CTX = require('./amcl-js/ctx');

• added package.json(for simplicity with the following stub)

  "name": "<name>",
  "version": "3.X.X",
  "description": "<description>",
  "main": "<path>/index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "<Author Name>",
  "license": "<some licence>"
}

Afterm them I used in my React project `npm install ' and was able to use the node package with your Javascript code with

const CTX = require("pesto-client").CTX;
let ctxBls12461 = new CTX('BLS12461');

As of my understanding and testing it should be possible with these changes that the code is usable in Javascript as before and it is possible in another Javascript files as functions from a library in plain Javascript. Additionally a person is able to build a npm package locally and can use it in Node.js or React projects (I don't know much about AngularJS, but maybe also there - I didn't tested it yet).

from core.

If you put together a Pull Request, and if it doesn't break anything, we will approve it. Unfortunately we don't have a JS expert on the team at the moment, so I cannot be of much help.

Mike

from core.

Ok. Let me do some tests and if everything works fine I can do a Pull Request and you or some of the contributors can double check it, such that there exist no side effects, which maybe I am not aware of. Thank you! I will let you know, when I am done with the tests.

Pascal

from core.

OK that's fine

from core.

Pull Request + Merge done.

from core.