Git Product home page Git Product logo

Comments (4)

danquack avatar danquack commented on August 12, 2024

@gingerlime in #116 (comment), you suggested this. I opened this issue to start the conversation around it, before doing any work. I was curious, how would do you plan on authenticate to docker hub? Would you expose cred secrets within the repository? Would you switch to deploying to GitHub registry instead?

from thumbor.

danquack avatar danquack commented on August 12, 2024

there's also this feature that was released recently https://docs.github.com/en/organizations/managing-organization-settings/disabling-or-limiting-github-actions-for-your-organization#adding-a-required-workflow-to-an-organization

from thumbor.

gingerlime avatar gingerlime commented on August 12, 2024

Thanks again @danquack. I'm not an expert on Github actions, but it (and also semaphore) allow defining secrets and using them, e.g. to authenticate to docker hub. That said, after the docker hub free organizations debacle, I'd be tempted to move to the Github registry anyway. I guess best to tackle one thing at a time though?

I'm slightly worried about how fast (or slow) Github actions might be. I think Semaphore provides faster instances, and it's taking some time even there. But build speed is not a huge concern anyway.

Are you okay starting on your own? if we can get something that builds the images and runs tests, that's a great start. I can then sort out secrets / pushing to the registry. Let me know if you have any questions!

EDIT: another challenge is whether we do this on master (thumbor 6.x) or on the 7.x branch. I'm still a bit unsure how to move forward with that one, since it needs more help.

from thumbor.

gingerlime avatar gingerlime commented on August 12, 2024

I think we can close this now :)

from thumbor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.