Comments (4)
@gingerlime in #116 (comment), you suggested this. I opened this issue to start the conversation around it, before doing any work. I was curious, how would do you plan on authenticate to docker hub? Would you expose cred secrets within the repository? Would you switch to deploying to GitHub registry instead?
from thumbor.
there's also this feature that was released recently https://docs.github.com/en/organizations/managing-organization-settings/disabling-or-limiting-github-actions-for-your-organization#adding-a-required-workflow-to-an-organization
from thumbor.
Thanks again @danquack. I'm not an expert on Github actions, but it (and also semaphore) allow defining secrets and using them, e.g. to authenticate to docker hub. That said, after the docker hub free organizations debacle, I'd be tempted to move to the Github registry anyway. I guess best to tackle one thing at a time though?
I'm slightly worried about how fast (or slow) Github actions might be. I think Semaphore provides faster instances, and it's taking some time even there. But build speed is not a huge concern anyway.
Are you okay starting on your own? if we can get something that builds the images and runs tests, that's a great start. I can then sort out secrets / pushing to the registry. Let me know if you have any questions!
EDIT: another challenge is whether we do this on master (thumbor 6.x) or on the 7.x branch. I'm still a bit unsure how to move forward with that one, since it needs more help.
from thumbor.
I think we can close this now :)
from thumbor.
Related Issues (20)
- Overwrite the default Thumbor host address 0.0.0.0 HOT 1
- Upgrade to thumbor 7.4.7 HOT 2
- Multiple TC_AWS_LOADER_BUCKET HOT 1
- multiarch build fails with SIMD HOT 5
- updating to 7.5.0 HOT 1
- Important omissions in: thumbor/thumbor/conf/thumbor.conf.tpl and duplicated HOT 4
- Parse errors no security at MinimalCompact/thumbor/blob/master/thumbor/conf/thumbor.conf.tpl HOT 5
- Are we affected by CVE-2023-5129 ? HOT 17
- Security Vulnerability - Pillow HOT 2
- Tornado latest version HOT 1
- HTTP request sent, awaiting response... 504 Gateway Timeout HOT 7
- smaller base image HOT 2
- No module named thumbor/server HOT 1
- Cannot import name 'Sentinel' from 'redis' (/usr/local/lib/python3.11/site-packages/redis/__init__.py) HOT 3
- AVIF support not available
- Migrate to `thumbor-aws` HOT 5
- Invalid port value error with Kubernetes
- Storage continues increasing after disable it HOT 2
- Upload image - HTTP 405 (Method not allowed) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thumbor.