Clicking outside formspec with a `field` causes a crash about minetest HOT 8 CLOSED

Looks like we explicitly disable RTTI for Irrlicht on MSVC (https://learn.microsoft.com/en-us/cpp/build/reference/gr-enable-run-time-type-information)

This was probably forgotten in minetest/irrlicht#268 because of the different option name.

from minetest.

Likely related to this dynamic cast, which needs run-time type information ("RTTI"). I don't see yet why Windows builds would not have this, however. How are you compiling?

from minetest.

How are you compiling?

Exactly as is described here: https://github.com/minetest/minetest/blob/master/doc/compiling/windows.md#a-using-the-vcpkg-toolchain-and-cmake-gui

from minetest.

Ah, sorry. I forgot to check inventories with fields when testing that PR.

vcruntime140.dll!00007ffef95e669d()
minetest.exe!GUIModalMenu::remapClickOutside(const irr::SEvent & event) Line 159
	at C:\git\minetest\src\gui\modalMenu.cpp(159)
minetest.exe!GUIModalMenu::preprocessEvent(const irr::SEvent & event) Line 384
	at C:\git\minetest\src\gui\modalMenu.cpp(384)
minetest.exe!GUIFormSpecMenu::preprocessEvent(const irr::SEvent & event) Line 4077
	at C:\git\minetest\src\gui\guiFormSpecMenu.cpp(4077)
[Inline Frame] minetest.exe!MainMenuManager::preprocessEvent(const irr::SEvent &) Line 80
	at C:\git\minetest\src\gui\mainmenumanager.h(80)
minetest.exe!MyEventReceiver::OnEvent(const irr::SEvent & event) Line 120
	at C:\git\minetest\src\client\inputhandler.cpp(120)
[External Code]
[Inline Frame] minetest.exe!RenderingEngine::run() Line 152
	at C:\git\minetest\src\client\renderingengine.h(152)
minetest.exe!Game::run() Line 1168
	at C:\git\minetest\src\client\game.cpp(1168)
minetest.exe!the_game(bool * kill, InputHandler * input, RenderingEngine * rendering_engine, const GameStartData & start_data, std::string & error_message, ChatBackend & chat_backend, bool * reconnect_requested) Line 4570
	at C:\git\minetest\src\client\game.cpp(4570)
minetest.exe!ClientLauncher::run(GameStartData & start_data, const Settings & cmd_args) Line 209
	at C:\git\minetest\src\client\clientlauncher.cpp(209)
minetest.exe!main(int argc, char * * argv) Line 263
	at C:\git\minetest\src\main.cpp(263)
[External Code]

from minetest.

I can reproduce with the MTG sign formspec.

I tested my PR with the MTG creative inventory, which also has a field[] (https://github.com/minetest/minetest_game/blob/1ce48351ea7b1586710c1e60e863e94ed06e2721/mods/creative/inventory.lua#L175), but I couldn't/can't reproduce there.

EDIT: Actually, the bug I reproduced is probably a different one.

from minetest.

Your call stack seems to confirm that it's indeed the dynamic cast that's causing this issue (though it seems to be off by one line?).

I can't reproduce on Ubuntu 22.04, building with clang. This is probably a Windows-only (?) build issue, where it compiles without RTTI. The logic introduced in the commit seems fine to me.

from minetest.

I tested my PR with the MTG creative inventory, which also has a field[], but I couldn't/can't reproduce there.

That is weird. I can reproduce it with the MTG creative inventory (built from recent master branch, on Windows 10).

I was testing the PR using the Void game, hence no field in the inventory formspec.

from minetest.

srifqi: I reproduced the wrong bug, the one I reproduced was caused by a WIP patch of mine.

Tested again with the builds from https://github.com/minetest/minetest/actions/runs/9113898824. I could reproduce with the msvc-x64-portable build, but not with the mingw64 build.

from minetest.