Git Product home page Git Product logo

Comments (8)

fluxionary avatar fluxionary commented on August 26, 2024 1

IMO the bug here is that i3 shouldn't depend on 3d_armor nor on skinsdb.

additionally, 3d_armor shouldn't depend on bakedclay (it doesn't even seem to use it? that's an easy fix)

from 3d_armor.

fluxionary avatar fluxionary commented on August 26, 2024 1

...its an autoclosed

i assumed so, but this autoclose is a natural language processing failure. a partial fix shouldn't have closed this. probably i could have phrased that differently? does github have a guide to how to not accidentally trigger the autoclose?

from 3d_armor.

BuckarooBanzay avatar BuckarooBanzay commented on August 26, 2024

If you are using the ethereal mod, could this be the root cause: mt-mods/moretrees#22 ?

from 3d_armor.

wsor4035 avatar wsor4035 commented on August 26, 2024

IMO the bug here is that i3 shouldn't depend on 3d_armor nor on skinsdb.
-snip-

i mean, it could not and use a register on mods loaded to handle that part, but at its core, it does provide features in itself that use apis/functionality from those mods, it should (optionally) depend on them

from 3d_armor.

fluxionary avatar fluxionary commented on August 26, 2024

should this have really been closed? the bakedclay dependency was only part of the issue, and i don't think everyone has agreed w/ me that i3's dependencies are the problem and not 3d_armor's dependencies.

in particular, i don't think that the API bit of 3d_armor should depend on nether, ethereal, etc. noting recipe ingredients should be part of the individual armor submods, right?

from 3d_armor.

wsor4035 avatar wsor4035 commented on August 26, 2024

...its an autoclosed issue since you linked it in the pr #90
image

from 3d_armor.

tenplus1 avatar tenplus1 commented on August 26, 2024

#100

from 3d_armor.

BuckarooBanzay avatar BuckarooBanzay commented on August 26, 2024

should be fixed with #100

from 3d_armor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.