SlotCrafting ContainerItem Destruction Logic Error about minecraftforge HOT 4 CLOSED

An item starts with no damage (0, zero). When it "reaches maxDamage" (ie, >=), it should be destroyed.

I'd venture to say that it's the ItemStack code needs updated.

from minecraftforge.

On the other hand, I view maxDamage as "this is the maximum damage an item can take before it is destroyed", so a maxDamage of 0 equals one use, or saying "it is destroyed when it is damaged".

Too much code already would use the logic in ItemStack, so if that were to be changed, every tool in every mod everywhere (as well as vanilla items) would lose one use.

from minecraftforge.

Valid point.

Now I can't decide. ;)

from minecraftforge.

2a749be

from minecraftforge.