Git Product home page Git Product logo

Comments (9)

petterroea avatar petterroea commented on June 1, 2024

I think this is a buildcraft problem. Go report it there ;)

from minecraftforge.

Cloudhunter avatar Cloudhunter commented on June 1, 2024

This is indeed an issue - it wouldn't be so bad if we could ask the inventory if we are allowed to pull from, or place in an item. The only way round it right now is to special case furnaces and other mods output slots - which is not ideal.

from minecraftforge.

petterroea avatar petterroea commented on June 1, 2024

Agree. There should be a boolean for the "acess type".

from minecraftforge.

taralx avatar taralx commented on June 1, 2024

Is it time to import BC's ISpecialInventory?

from minecraftforge.

psxlover avatar psxlover commented on June 1, 2024

You shouldn't be able to put anything in the output slot, only in the two input slots. Probably something is messed up and instead of adding the item to the fuel slot it adds it to the output slot.

from minecraftforge.

taralx avatar taralx commented on June 1, 2024

ISidedInventory doesn't have a concept of a "remove-only" inventory. So if you can pipe out, you can pipe in. That's the thing about the exploit. Fixing that requires either extending ISidedInventory or using a new interface like ISpecialInventory.

from minecraftforge.

Xfel avatar Xfel commented on June 1, 2024

An other version would be adding a new Interface IRestrictiveInventory (or something like that) with a method:
boolean isItemValid(int slot, ItemStack stack)
This would allow a much more detailed control over item additions. The restrictive gui slots are already implemented that way (look at net.minecraft.src.Slot.isItemValid). If wanted, the slot class could also be patched to call the new method if available.

from minecraftforge.

Xfel avatar Xfel commented on June 1, 2024

I just made up some drafts for the IRestrictiveInventory class and the TileEntityFurnace:
https://dl.dropbox.com/u/63263434/Minecraft/IRestrictiveInventory.java
https://dl.dropbox.com/u/63263434/Minecraft/TileEntityFurnace.java.patch

from minecraftforge.

 avatar commented on June 1, 2024

This is not a robust enough solution, I'll start riding Overmind about this he was working on a better solution.

from minecraftforge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.