org-modern-agenda does not find all keywords in custom agenda views about org-modern HOT 15 CLOSED

See https://lists.gnu.org/archive/html/emacs-orgmode/2023-03/msg00145.html for a patch against upstream.

from org-modern.

Okay, I will close this here. I checked the Org source and it is really unclear if the keywords should be made available via these variables. I also don't understand why we even have the separate *-for-agenda variables. Instead the normal keyword variables could be bound in the agenda buffer. Furthermore I don't understand why all these variables are public if they are supposed to be implementation details. Most global variables are also undocumented, which according to my standards is unnacceptable. The Org code base has grown organically and it is very chaotic. I hope that it gets cleaned up over time. There have been improvements already but progress is not as fast as one would hope. Understandably, such janitorial work does not seem to be a priority of the maintainers. My approach is usually to refactor a bit and clean up before adding new functionality, but this is easier said than done for a large system with a long history.

from org-modern.

from org-modern.

Thanks! It seems the fix got already applied in the Org main branch, see https://lists.gnu.org/archive/html/emacs-orgmode/2023-03/msg00183.html.

from org-modern.

Thanks for the report. It seems that the variable org-done-keywords-for-agenda is always set properly. Only org-todo-keywords-for-agenda is not initialized for C-c a n. I consider this a bug in Org. So we should not add a workaround here.

from org-modern.

from org-modern.

Was this bug reported upstream? I see that org-modern still doesn't work with custom agendas running an up-to-date org-mode master branch.

from org-modern.

@skangas I am not sure. For the agenda styling, this is the relevant code:

It is unclear on which variables we can rely in the agenda buffer.

from org-modern.

Not sure if this is related, but the alignment in the custom agenda is also messed up:

The alignment also changes when the files (and headlines) are visited.

from org-modern.

@dschrempf For me everything is aligned. This probably depends on some additional settings in your config. The screenshot you've posted is also too small to tell. Can you create a minimal example which shows the issue on emacs -Q?

from org-modern.

No one found a workaround for this?

from org-modern.

@AndreaOrru I think this should be fixed upstream in Org itself. The variables don't seem to be initialized properly, see #26 (comment). You could report a bug on the Org bug tracker.

from org-modern.

from org-modern.

Sorry for bumping this, but is there a regression? I am on Org 9.6.9, and I again have misaligned TODO items and org-todo-keywords-for-agenda nil.

Adding the following snippet to my init file fixes the issue:

  (add-hook 'org-agenda-finalize-hook
            (lambda ()
              (setq-local org-todo-keywords-for-agenda '("TODO" "NEXT" "WTNG"))))

Funny enough, org-done-keywords-for-agenda is set properly.

from org-modern.

@dschrempf Yes, it seems there is a regression in Org if this stopped working again. See also #158.

from org-modern.