Better preview for Emacs default completion about consult HOT 8 CLOSED

Sure I'll look into it. I think probably just after every change to the minibuffer contents, we should test-completion, and if it is a full candidate, update the preview. I'll test that and make a pull request if it seems good enough.

from consult.

Thanks! You beat me to it. I just tested it and works great, including the tricky case of tab cycling which the previous approach wouldn't work for.

from consult.

Yeah. If you have time to clean that up please do. This is a mess. I advise three functions but I have no idea what I am actually doing.

from consult.

How would you feel about lumping in embark-completing-read with the default completion? You can just change (eq completing-read-function #'completing-read-default) to (memq completing-read-function '(completing-read-default embark-completing-read)).

from consult.

@oantolin I guess that would be okay. Btw do you know if there is a better way to distinguish icomplete from default? Icomplete does not overwrite the function.

from consult.

@oantolin I guess that would be okay. Btw do you know if there is a better way to distinguish icomplete from default? Icomplete does not overwrite the function.

No, I don't know of a better way. I would have done it the same way you did.

from consult.

See here 00c820d. I would like if we could find a better way to do this detection, but for now it is okay.

from consult.

Perfect, thanks! It would be nice to have a cleaner way of detecting the various completion systems, but this isn't too bad.

from consult.