Comments (6)
Closing due to realizing that the ref
option was required. Was under the impression that it would have been picked up by TsMorphMetadataProvider.
from mikro-orm.
Let's keep this open, I want to review it first (probably this evening). ts-morph should pick this up, and it might be failing because you use it with the Opt
type intersection. Note that your repro does not use ts-morph.
from mikro-orm.
Yes, I saw that before I closed the issue. Required a bit of refactoring for it to work. It has now been added.
from mikro-orm.
Yeah, this is surely something to fix, it's about the Opt
type intersection. Note that in your repro you test whether the value is true
- it never will be the value itself with the Ref
wrapper, it is always the Reference
class (in this case ScalarReference
), which wraps the value.
from mikro-orm.
So the problem here is that the TS compiler API returns the type for hasBarPost
as any
for some reason. If you use hasBarPost!: Opt<Ref<boolean>>
it does work fine though.
edit: Damn, I again forget that the compiler API likes to give any
in the ORM test suite while it works outside of it. So the type name actually resolves to (import("/Users/adamek/htdocs/mikro-orm/reproduction/node_modules/@mikro-orm/sqlite/index").ScalarReference<false> | import("/Users/adamek/htdocs/mikro-orm/reproduction/node_modules/@mikro-orm/sqlite/index").ScalarReference<true>) & { [__optional]?: 1 | undefined; }
, and we fail to process that properly. Uh and why the hell it expands boolean
to true | false
.
from mikro-orm.
Wow, what a simple fix for such a weird issue haha
from mikro-orm.
Related Issues (20)
- findOne/findOneOrFail should work without where param or with empty where param HOT 1
- SyntaxErrorException: [...] - syntax error at or near "<"
- MetadataError: Source file '$' not found. Check your 'entitiesTs' option [...]
- Explicit serialization throws error when serializing new embeddable HOT 4
- Problem with detected db_name
- Allowed different entity with same name
- docs: callout potentially breaking typescript version updates
- Renaming indexes generates faulty migration, drops existing indexes HOT 3
- docs: redundant nav link in the footer HOT 2
- QueryBuilder `execute` Method Doesn't Properly Map Embeddables HOT 7
- Composite primary keys in relations populates foreign keys with incorrect values HOT 4
- deprecated subdependencies
- array out of bounds error with columns shared in composite PK and FK HOT 1
- createForeignKeyConstraints Configuration options support in Migrations HOT 1
- Subsequent queries from identity cache don't honor field settings or exclude options HOT 1
- Not able to run migrations in MS SQL Server HOT 6
- docs: incorrect example code, bug: entity discovery
- MS SQL Get Database Existence query fails during application start HOT 2
- Mikro orm property initalizers not working when using minifed builds
- Nested Embeddables Prefix Not Respected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mikro-orm.