Library is broken in environment using CommonJS modules about canvas-gauges HOT 6 CLOSED

Fixed in commit ab10951

Will be released in v2.1.0

from canvas-gauges.

Thanks, will fix that in 2.1.0

Yes, there is a reason of such build. It provides an ability to get minimum code.

from canvas-gauges.

Okey, thank you. Should I open PR with my current fix or you're gonna do the work yourself?

from canvas-gauges.

these kind of things:

if (matchMedia) {
 // ...
}

will produce uncaught ReferenceErrors in the environments where is it not defined, so such kind of fix is not acceptable.

it should be changed to something like:

if (typeof matchMedia !== 'undefined') {
 // ...
}

or I guess it will be much better to make more generic changes over ns definition...

from canvas-gauges.

Yes, you're right about ReferenceErrors. Probably it is also better to have more generic change for ns. Let me know if I can provide any help! Your library saved me hours and hours of work :)

from canvas-gauges.

sry... how about being able to specify your own time provider when creating the gauge? would that help?

from canvas-gauges.