Git Product home page Git Product logo

Comments (3)

mikenicholson avatar mikenicholson commented on July 24, 2024

Is this a common practice? What is driving this need? In my experience with using JWTs for authentication the JWT is provided in whole by the party being authenticated. Modifying the JWT as part of authentication seems odd.

I would suggest that you modify the partial JWT from the request before invoking this authentication module. The modified JWT can be added to the request object and you can use a custom extractor function to retrieve it and authenticate it with this module.

from passport-jwt.

manuel-di-iorio avatar manuel-di-iorio commented on July 24, 2024

The use case is to make slightly hard for an user to understand how the token is built (which sign algorithm). Not really odd, or yes?

I would suggest that you modify the partial JWT from the request

It looks like a good choice, so before invoking passport.authenticate('jwt', etc..

For anyone else:

if (req.headers.authorization)
    req.headers.authorization = "JWT " + header + req.headers.authorization;

passport.authenticate('jwt', etc...

Of course, after have modified how the client sends the token in the header and using the .fromAuthHeader() extractor

from passport-jwt.

manuel-di-iorio avatar manuel-di-iorio commented on July 24, 2024

@themikenicholson As you can see, a unified way for every extractor would be better

from passport-jwt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.