Git Product home page Git Product logo

Comments (6)

mikel avatar mikel commented on July 20, 2024

I understand why you might be doing this, but I don't get any errors, can you give me a failing test case?

from mail.

e2 avatar e2 commented on July 20, 2024

I just wanted to report the same thing.

This happens e.g. when running Rails tests under Ruby 1.9
A more general solution is adding:

# encoding: us-ascii

at the beginning of the file.

To reproduce:

% ruby  -Ku -e 'require "mail/patterns"' 
/home/myaccount/.rvm/gems/ruby-1.9.1-p378/gems/mail-2.2.0/lib/mail/patterns.rb:24:in     `<module:Patterns>': invalid multibyte character (ArgumentError)

from mail.

namelessjon avatar namelessjon commented on July 20, 2024

I've also been bitten by this when explicitly using a utf-8 encoding with ruby

from mail.

e2 avatar e2 commented on July 20, 2024

Could you please release a gem with this fix? The fix is trivial, breaks nothing and allows people to run Rails ActionPack tests on Ruby > 1.8 without manually patching every mail gem in every Ruby version / Rails bundle.

Thanks ! :)

from mail.

mikel avatar mikel commented on July 20, 2024

Can you do me a favour and see if the current HEAD of this file fixes it? The commit was:

http://github.com/mikel/mail/commit/1e050b3ecfafb12626243a1267ac60a67aaa6249

I merged a change from Jeremy that sets the encoding type of the file that should handle this problem... but I need to know if it works on someone who has this issue.

Mikel

from mail.

mikel avatar mikel commented on July 20, 2024

No further reports, I am closing this ticket. Please re-open if it is still a problem.

from mail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.