Sendmail argument change breaks Rails usage of Sendmail about mail HOT 10 CLOSED

Hi.

Just for the sake of feedback : mail 2.8.0 is indeed breaking my rails application in production when trying to deploy on AWS Beanstalk.

I am running ruby 3.0.5 and rails 6.1.7. Reverting back to 2.7.1 fixes it back.
Did not really find out what the error was, but something related to an uninitialized constant Mail::SendMail.

Hope this will help.

from mail.

#1547 includes changes to test.yml allow the PR to run as a GH action.

The unadorned draft is #1545

from mail.

Seems serious. @mikel how about a fix that doesn't raise here

from mail.

@eval yes, that makes sense, we should make that a PR and get that deployed as 2.8.1 right away. If we get a string, split it and put it back in.

from mail.

Agree with restoring support for string.

However if valid arguments can contain blanks, it makes correctly splitting the string tricky.
An alternative would be to append the original string when building the command.

Whilst this would not be as safe against shell mis-interpretation, it is very unlikely that the arguments provided by callers are derived directly from user input.

As well as emitting a warning, it would be useful to document why a string is deprecated.

from mail.

However if valid arguments can contain blanks, it makes correctly splitting the string tricky.
An alternative would be to append the original string when building the command.

Good point @sebbASF. But adding an argument with spaces doesn't work either right? E.g. IO.popen(["ls", "-l -h"]) fails.
So it seems to me that when passed a string, the command should be a string.

from mail.

Good point, agreed

from mail.

Current draft: #1547

from mail.

Same here, this broke multiple production Rails apps. Reverting to 2.7.1.

from mail.

Fixed via #1545

from mail.