v4.43.1 doesn't build with go <1.21 about yq HOT 2 CLOSED

Hello,

The requirement on go 1.21 was set in commit bbe196b "feat: upgrade go.mod to 1.21 (#1830)". This is related to the patch on pkg/yqlib/operator_omit.go because it uses a max() function that is apparenty not available in go 1.20. Preserving go 1.20 compatibility would be great because that version is available in el8 and el9.

So far I was able to build our RPM package without too much hassle that patch:

--- a/go.mod
+++ b/go.mod
@@ -30,4 +30,4 @@ require (
        golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
 )
 
-go 1.21
+go 1.20
--- a/pkg/yqlib/operator_omit.go
+++ b/pkg/yqlib/operator_omit.go
@@ -5,6 +5,13 @@ import (
        "strconv"
 )
 
+func max(a, b int) int {
+    if a > b {
+        return a
+    }
+    return b
+}
+
 func omitMap(original *CandidateNode, indices *CandidateNode) *CandidateNode {
        filteredContent := make([]*CandidateNode, 0, max(0, len(original.Content)-len(indices.Content)*2))

Regards,
Julien

from yq.

Sorry yq does not have backwards compatibility for older versions of go. Often the go version is bumped for security issues.

from yq.