number sign # cause blank line about yq HOT 6 CLOSED

yq '... comments = "" | .spec.service.type="NodePort"'

it's good way.

from yq.

Weird I don't get that blank line when I try your example locally.

from yq.

Oops yes I do - the new line in the example you had didn't copy over for some reason.

from yq.

Ok looking into it - it seems that the underling yaml parser attaches the newlines to the "# memory" line comment; which itself belongs to the '.spec.requests' node. When a new node is added below, it goes beneath the printed comment which is why you're getting those spaces.

There's not much I can do to control this from a coding perspective, but here are a couple of options to workaround it:

a) put a blank line between 'storage' and the comment:

  storage: 10Gi
  
  # limits:
  #   cpu: 2000m
  #   memory: 2Gi

This will treat the comment block as a footer, so the new service node will appear above it

Or b) Trim the trailing new lines from the file

from yq.

Thanks，now i must use sed to delete the blank line，but using sed is somewhat ugly.

wget https://raw.githubusercontent.com/pingcap/tidb-operator/1.5.1/examples/basic/tidb-dashboard.yaml
yq -i '.spec.service.type="NodePort"' --inplace tidb-dashboard.yaml
sed -i '/^$/d' tidb-dashboard.yaml

Can yq ignore all lines starting with the # sign? these comment lines have no meaning for the structure of the yaml file.

Eg: let yq to ignore # line then use ----inplace

# cat tidb-dashboard.yaml | grep -v '^ *$\|^ *#'
apiVersion: pingcap.com/v1alpha1
kind: TidbDashboard
metadata:
  name: basic
spec:
  baseImage: pingcap/tidb-dashboard
  version: latest
  clusters:
    - name: basic
  requests:
    storage: 10Gi

from yq.

Yep, you can use yq to remove all the comments:

yq '... comments = "" | .spec.service.type="NodePort"' examples/data1.yaml

from yq.