dependency problem; unable to get test environment working about typescript-fundamentals HOT 7 CLOSED

I just updated the lock file, with an upgrade to node-sass.

Before

yarn why har-validator

=> Found "[email protected]"
info Reasons this module exists
   - "node-sass#request" depends on it
   - Hoisted from "node-sass#request#har-validator"

After

yarn why har-validator

=> Found "[email protected]"
info Reasons this module exists
   - "node-sass#request" depends on it
   - Hoisted from "node-sass#request#har-validator"

from typescript-fundamentals.

I'm not sure if this is the best approach, but based on what I found here, I just updated the relevant section in the yarn.lock file to 5.1.3.

So change this:

har-validator@~5.1.0:
  version "5.1.2"
  resolved "https://registry.yarnpkg.com/har-validator/-/har-validator-5.1.2.tgz#a3891924f815c88e41c7f31112079cfef5e129e5"
  integrity sha512-OFxb5MZXCUMx43X7O8LK4FKggEQx6yC5QPmOcBnYbJ9UjxEcMcrMbaR0af5HZpqeFopw2GwQRQi34ZXI7YLM5w==
  dependencies:
    ajv "^6.5.5"
    har-schema "^2.0.0"

To this:

har-validator@~5.1.3:
  version "5.1.3"
  resolved "https://registry.yarnpkg.com/har-validator/-/har-validator-5.1.2.tgz#a3891924f815c88e41c7f31112079cfef5e129e5"
  integrity sha512-OFxb5MZXCUMx43X7O8LK4FKggEQx6yC5QPmOcBnYbJ9UjxEcMcrMbaR0af5HZpqeFopw2GwQRQi34ZXI7YLM5w==
  dependencies:
    ajv "^6.5.5"
    har-schema "^2.0.0"

And try the yarn install command again and it should work. Basically it appears the har-validator package was tagged under the wrong version.

What I don't know is if I was supposed to update both of those versions, or just the top one. It would be nice to get some confirmation here.

from typescript-fundamentals.

thanks for the prompt response. modifying the version does indeed seem to allow yarn to install dependencies correctly.

However, I'm now wondering if the test script is working as expected. For example
cd exercises; npm test color-functions

does not run the tests for "color-functions". It looks to me as if the scripts/test/index.sh should contain
./node_modules/.bin/jest --no-cache --watch $1
rather than
./node_modules/.bin/jest --no-cache --watch $2

from typescript-fundamentals.

Hmm, I don't think you need to cd into the exercises directory. Did you try npm test color-functions from the base directory? Do you get an error when trying to run it?

from typescript-fundamentals.

from typescript-fundamentals.

Weird, I totally see what you mean, but mine works just fine with:

npm test color-functions

Even though my index.sh is:

#!/bin/bash ./node_modules/.bin/jest --no-cache --watch $2

I tried:

npm test junk color-functions

And that still works too.

from typescript-fundamentals.

🎉 This issue has been resolved in version 1.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from typescript-fundamentals.