Git Product home page Git Product logo

Comments (1)

pseudoralph avatar pseudoralph commented on July 26, 2024 1

@vany0114 I also share your concern— throwing a ResourceLockederror when a vote goes against for a given instance and then handling such errors as this more generic ExecutionError is less than ideal.

I was playing around w/ adding this to the _execute event loop

        while (true) {
            const { vote, stats } = await this._attemptOperation(script, keys, args);
            attempts.push(stats);
            // The operation achieved a quorum in favor.
            if (vote === "for") {
                return { attempts };
            }
            if (vote === 'against') {
                throw new ResourceLockedError("Quorum Achieved. This instance lost vote")
            }

re-throwing as ResourceLockedError (which is also an exported class of this module) would then allow the consumer of this package to ignore these types of expected errors and only throw for other, unhandled errors.

@mike-marcacci is this something I should create a PR for? i do notice a large backlog of unreviewed PRs and am wondering if this would be a welcome addition

from node-redlock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.