Comments (5)
Thank you for your response
I created local module with Enumerable extension (patch adds .fromObject
method) and updated linq module to have type definition for the new method. It's suitable for me
from linq.
Good find, I don't think we need to keep that logic. I would change it to Array.isArray(obj)
, but need to check potential problems.
from linq.
I've done some tests and it seems like this change is not a good idea. Using Array.isArray(obj)
(or instanceof
) instead of typeof obj.length == Types.Number
would exclude array-like objects, most notably the arguments
object and return values from DOM functions like document.getElementsByTagName()
that return a list of elements.
You can consider this issue a small limitation of the library, but it's probably better to change the name of your length
property to avoid other problems down the line.
Also a small correction to your code, when converting to object use .toObject(i => i.key, i => i.value);
(without the capitalization)
from linq.
Is it possible to create method .fromObject
or something like this?
We cannot change name of length
property because we have too many models with this property. So renaming will take too much time to support it across the system.
from linq.
I think it would be odd to create a separate method for such a narrow use-case.
But you can of course create your own helper method which will transform your object to an array of key-value pairs.
from linq.
Related Issues (20)
- Typescript, generic Linq functions
- Enhancement: Async / Await functionality
- Contains Method does not Delivers True HOT 2
- Question: How to use Join Correctly? HOT 1
- Can't the groupby method groupby multiple keys?
- How to use linq in nested of nested object
- Does it support iterables? HOT 1
- Support User-Defined Type Guards in where()
- How to use latest linq in html HOT 2
- Add toMap HOT 1
- Type inference for .toObject HOT 3
- how to use select with chained groupby HOT 1
- Overloaded `all` with extra predicate args like `every`
- how to use left join? HOT 2
- Help: OrderByDescending chain with dates not triggereing second orderBy function (but ok if type is number) HOT 2
- Missing IDictionary.key and IDictionary.values
- Enumerable.from is missing Array[] overload. HOT 1
- Transfer ownership of this package HOT 3
- Iterable support HOT 7
- How to extend Enumerable (IEnumerable?) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linq.