Git Product home page Git Product logo

Comments (4)

miguelmoreto avatar miguelmoreto commented on July 29, 2024

Hello @ldemattos !

thanks for your help. If I understood correctly your comtrade record is broken, right? I agree with you that pyContrade should not crash in this case, but return to the user an indication of that. In you solution is this your idea or are you trying to read de broken comtrade? If think that a broken cfg should not be readed.

Best regards,

from pycomtrade.

ldemattos avatar ldemattos commented on July 29, 2024

Hi @miguelmoreto !

My pleasure to help!

I don't know if it is broken or those are optional fields, since the record that I'm analyzing opens correctly on other oscillographic readers. I'm not used IEEE Comtrade standard details. Sorry.

The solution that I have proposed simply check if the missing fields exists, and if TRUE, reads it, or else skip it. It's a very simple solution that do not hinder by no means the reading of files that contains all fields. Nevertheless, it make the program more reliable.

I do agree that a broken cfg should not be opened, however this one is a keeper.

Best regards,

from pycomtrade.

miguelmoreto avatar miguelmoreto commented on July 29, 2024

Ok. Can you include some comments in the code about these modifications? After that I will merge your PR. Best regards.

from pycomtrade.

miguelmoreto avatar miguelmoreto commented on July 29, 2024

Done! PR merged!

from pycomtrade.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.