Git Product home page Git Product logo

Comments (4)

TronPaul avatar TronPaul commented on May 17, 2024

Think I fixed it in #11, but client requested acks can't be unit tested yet. That should be solved before closing this issue.

from flask-socketio.

TronPaul avatar TronPaul commented on May 17, 2024

Looking at the gevent-socketio library adding this to received wouldn't be correct because the return value of the handler methods isn't sent in an ack unless requested by the client. I think I'd store all the return values of the handlers in a list on the socket. Will add pull request.

from flask-socketio.

TronPaul avatar TronPaul commented on May 17, 2024

The pull request now solves both parts of the issue. The test client now returns what was returned by recv_*. Code that wishes to test acks can now store that return value and assert on it. No checks are made if it can or cannot be sent by the library (is it jsonable, etc).

from flask-socketio.

miguelgrinberg avatar miguelgrinberg commented on May 17, 2024

Closing, since this is fixed by #11

from flask-socketio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.