Comments (3)
Hi! Contributions are so much welcome!
- Most of the styles are borrowed from angular material
- There isn't a specific structure. We just keep styles in separate files for each component. I've considered using this: https://github.com/ebryn/ember-component-css
- I guess we should follow
ember-try
and always support latest beta and the two latest stable versions - We use github for everything.
- There is plenty of stuff left to do! Please read #3 and the fantastic menus issue #65
- Menus will be really fun to implement. :) I just don't have the time right now. Could use some help.
Thank you for your interest!
from ember-paper.
@miguelcobain I was just noticing now that there's some variance in what names the CSS styles get.
I see somethings like md-icon
as a tag name, and paper-icon
as the class name. Where as md-checkbox
has both tag name, and class name the same.
This could cause some confusion down the road. It may not be huge priority right now, but I was thinking I could create a wiki page for contributing so it'd be easier to keep it updated (doesn't require a PR, or push to update it). We don't necessarily need to go update all the current components to match immediately after deciding, but if we come up with a convention now there'll at least be a consistent expectation set going forward of how to code it, and how to style it in app.
Personally, I'd like to start forming an outline on how to answer questions like:
- What format do we give the components' class names?
- If we have a
paper-wrapper
component, what name do we give an element that is within that component? e.g.,paper-wrapper_button
,paperwrapper-button_text
, etc. - Is coffeescript/sass/emblem/etc. ok? (I think that's an assumed NO, but I'd probably toss that in the doc too.)
- Do the tag names need to match the class names? IMPO, yes they should
- Do we use
paper-component
, ormd-component
across the board?
Specifically that last one is another talking point. md-
is great because it's so short, but it is primed to conflict with the expected xs
, sm
, and md
breakpoints found in many other frameworks.
Anyway, lots of thoughts here... but figured I should post it for discussion.
from ember-paper.
I also whipped together this PR to provide some better structure for the scss files.
I could address some other organization changes in it if anything comes of this discussion.
from ember-paper.
Related Issues (20)
- Deprecations when upgrading to Ember >= v3.20.x, {{-in-element}} HOT 1
- Paper select errors when menu is closed on ember > 3.17 HOT 3
- Form elements that accept `required` don't set an A11y attribute on the child element
- PaperSelect with selected=0 HOT 1
- Tab Component lacks accessible role="tab"
- Paper Tabs Pagination Always Visible
- Select ARIA violation around not having an accessible name
- paper-menu.item.shouldRenderButton doesn't handle the case when click handler is installed differently HOT 2
- Paper chips component throws an 'focus' error with readOnly property as true
- paper-chips inside paper-form: form is sent and closed when adding new tag (press Enter)
- error when building app with ember-paper HOT 8
- Ghost basic-dropdown-content once paper-menu closed HOT 1
- Remove usage of liquid and any other confusing irrelevant library from the docs
- With this being deprecated, what should we replace it with? HOT 2
- Add support for `renderInPlace` to `PaperSelect`
- Does not install with Ember 4.1.0 HOT 4
- [Embroider:MacrosConfig] the given config from '.../ember-get-config' for packageName 'undefined' is not JSON serializable. HOT 5
- Quest: Ember 4 + Octane HOT 1
- Button HOT 1
- How does the docs site get deployed? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-paper.