Git Product home page Git Product logo

Comments (18)

altrim avatar altrim commented on May 15, 2024

I think @BryanHunt is using Safari. On the latest safari I am checking the effects are not working on buttons and same for switches, checkboxes and radio buttons are broken.

from ember-paper.

miguelcobain avatar miguelcobain commented on May 15, 2024

Ember-paper or angular material or both?

from ember-paper.

altrim avatar altrim commented on May 15, 2024

I am noticing just for ember-paper demo the issues. Angular material works fine on safari

from ember-paper.

miguelcobain avatar miguelcobain commented on May 15, 2024

Ok, thanks.

Don't have my mac around right now. Will try to have a look when i do.

from ember-paper.

BryanHunt avatar BryanHunt commented on May 15, 2024

Yep, I'm on a Mac using Safari :) Yep, effects seem to be broken. I see the effects on the Angular button but not the paper button. IMHO, the wave effect on the materialize site is better than the Angular one.

from ember-paper.

miguelcobain avatar miguelcobain commented on May 15, 2024

Ok, thanks. Don't know what may be happening. 😕
Side note: the discussion should be which effect is closer to specs (I don't know that answer).

from ember-paper.

BryanHunt avatar BryanHunt commented on May 15, 2024

Just to close out the side note. The Angular version seems to match the spec. I'm all for going with the spec.

from ember-paper.

btecu avatar btecu commented on May 15, 2024

Not just the effects but most of the things seem broken in Safari:

screen shot 2015-02-10 at 7 23 35 pm

screen shot 2015-02-10 at 7 23 48 pm

screen shot 2015-02-10 at 7 31 05 pm

from ember-paper.

BryanHunt avatar BryanHunt commented on May 15, 2024

I think the problem is more fundamental than effects. It looks like the CSS is very broken in general on Safari - there are no headers on the sample application at all. Looks great under Chrome.

from ember-paper.

miguelcobain avatar miguelcobain commented on May 15, 2024

I could use some help in finding this bug. What kind of headers are missing?

from ember-paper.

BryanHunt avatar BryanHunt commented on May 15, 2024

Here is a screenshot of what I get when I open http://miguelcobain.github.io/ember-paper/

ember-paper_-the_ember_approach_to_material_design

from ember-paper.

BryanHunt avatar BryanHunt commented on May 15, 2024

And here is the computed style for md-nav-container as an example.

ember-paper_-the_ember_approach_to_material_design

from ember-paper.

green-arrow avatar green-arrow commented on May 15, 2024

@BryanHunt @miguelcobain looks like the root problem is Safari not understanding display: flex. By adding display: -webkit-flex, things start looking better. Looks like we need to just add in the -webkit prefix for flexbox layouts in order for this to work in Safari.

I think pulling in Autoprefixer and running that against our CSS would solve the issue nicely.

from ember-paper.

miguelcobain avatar miguelcobain commented on May 15, 2024

What about this https://github.com/kimroen/ember-cli-autoprefixer ?
Our sass compilation is currently a "workaround", so it may not make sense to use this addon.

from ember-paper.

green-arrow avatar green-arrow commented on May 15, 2024

I'd have to read up on how to inject properties into EmberApp. I've never used an addon within an addon before 😛

For this pass I just wanted to follow the patten you were already using in postinstall.sh.

from ember-paper.

miguelcobain avatar miguelcobain commented on May 15, 2024

Let's stick with this for now.
I'm hoping to have a better sass build approach when this is solved: ember-cli/ember-cli#2905

from ember-paper.

green-arrow avatar green-arrow commented on May 15, 2024

Sounds like a plan.

from ember-paper.

BryanHunt avatar BryanHunt commented on May 15, 2024

AwesomeSauce!!

from ember-paper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.