.increment() not working called before a .push() about react HOT 7 CLOSED

Oooh interesting, I didn't even think to put anything else really on the models. I'll update my code to do it that way instead.

Also great work on this library! I was at Framework Summit a few weeks ago when you talked about this and it got me really interested.

from react.

UPDATE:
If I chain the transitions, it works fine

const inc = model => {
    model
        .count.increment()
        .posts.push({ id: Date.now() });
  };

from react.

Marques,

That is very interesting. I would have expected your initial example to work as well.

That said, if it is possible it is best to include the transitions on the actual microstate models themselves like I have done in this example https://codesandbox.io/s/31x8llnjjm

This has a number of benefits:

1. There is no intermediate state emitted for the increment and the push
2. It is batched logically and can be re-used around your application
3. this is subtle but important, the m.inc function is stable and will not trigger re-renders when the model changes.

from react.

Glad you like it! Please keep the questions coming. I'm leaving this issue open, since even though there is a good work around, it seems like it could still very well be a bug.

from react.

@cowboyd did we fix this?

from react.

I don't know actually. The problem is that the model reference is "stale". Note that the changes in thefrontside/microstates#317 will make it no longer chainable.

from react.

I'm going to close this issue. @mwq27 feel free to reopen it if this issue is not resolved for you.

from react.