Comment Thread API: Newly created comment threads no longer auto-focus about vscode HOT 12 CLOSED

I can't reproduce this. Can you share a code snippet?

@alexr00 Thanks for the reply! I believe the following is a minimal example, let me know if it works for you:

1. Create a comment controller

this.commentController = vscode.comments.createCommentController(
      "codeium-command",
      "CodeiumCommand"
);

2. Create a comment thread with any doc and range

const commentThread = this.commentController.createCommentThread(
      docUri,
      range,
      []
);
commentThread.label = "Codeium Command";
commentThread.collapsibleState =
      vscode.CommentThreadCollapsibleState.Expanded;

Expected behavior: opens the comment thread where the input is auto-focused
Actual behavior: open the comment thread but the input is closed

from vscode.

We aren't planning on having another recovery release, so you can see our next approximate release time in the iteration plan.

from vscode.

Yes, I have this too, very annoying.

from vscode.

I can't reproduce this. Can you share a code snippet?

from vscode.

Hi @alexr00, I'm a Codeium user and I can reproduce it by adding the Codeium extension and pressing Cmd + I to open a refactor panel. Not sure about snippet because I'm not a Codeium developer.

from vscode.

Hmm. I'm doing basically the same thing, but I can't repro. I've pushed my test command to the comment sample. You can see the change here: https://github.com/microsoft/vscode-extension-samples/compare/alexr00/createEditableThread?expand=1, and you can clone that repo and check out the alexr00/createEditableThread branch to try it out.

from vscode.

I tested out the change and it seems like it opens the comment box with an existing comment box in edit mode. While this does open the input to be focused, it also adds a "Reply" at the bottom of the comment box which is undesirable.

const thread = commentController.createCommentThread(vscode.window.activeTextEditor.document.uri, new vscode.Range(line, 0, line, 0), [new NoteComment('', vscode.CommentMode.Editing, { name: 'vscode' })]);

If I remove the comment and start with an empty thread, we're back at the original issue which is that the comment box is not open

const thread = commentController.createCommentThread(vscode.window.activeTextEditor.document.uri, new vscode.Range(line, 0, line, 0), []);

@alexr00 Is there a way for us to:

• Open the comment box with the input focused
• No existing comments / reply at the bottom
  Thank you!

from vscode.

Thanks for finding the difference between our samples!

from vscode.

@alexr00 thqnk you for the swift fix!

from vscode.

@alexr00 Thank you!! Is there a rough estimate on when this might make it to the next VS Code release?

from vscode.

This bug has been fixed in the latest release of VS Code Insiders!

@1matthewli, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 4580ba5 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

from vscode.

Looks good now in insiders!

from vscode.