Git Product home page Git Product logo

Comments (6)

mifieldxu avatar mifieldxu commented on July 23, 2024 1

hello! i'm new here. it turned out that the vscode-common repo doesn't actually have glob.ts in it. i implemented a solution to this with the vscode-anymatch package, which is just a fork of anymatch, but since it's a dependency for vscode-chokidar, i assume it's ok to use.

i also wrote some additional tests to make sure it works as expected, presuming that fileMatch is intended to be glob patterns.

i went ahead and submitted a pull request, but do feel free to do whatever you'd like!

from vscode-json-languageservice.

aeschli avatar aeschli commented on July 23, 2024 1

Sorry, I'm just swamped with other priorities. I'm not against the suggested changes, the node_module dependency is not a problem, just causes extra administrative work for which I didn't have had time yet.

from vscode-json-languageservice.

aeschli avatar aeschli commented on July 23, 2024

As written in the API comment, currently we only support '*', not glob
I'm not opposed to allow glob as well but ideally implement it ourselves inside json-languageservice so I don't need to spend any time with legal approvals.

from vscode-json-languageservice.

Trias avatar Trias commented on July 23, 2024

Understandable. Maybe we can use this code: https://github.com/microsoft/vscode/blob/master/src/vs/base/common/glob.ts?

Not sure tough how to integrate this code into into this library.

I realized that allowing glob pattern (obviously) is a breaking change, so probably we need to provide an alternative option in addition to fileMatch.

from vscode-json-languageservice.

ssbarnea avatar ssbarnea commented on July 23, 2024

Do we have any chance to get a some progress on this? Currently due to the very limited implementation it is impossible to correctly select schemas for some real world use-cases.

I am wondering it would be ok to just assume that **/ -> .* and * -> [^\/]*. Two stars should cross directory boundaries but one star should only match anything but the directory separator.

Do i have the impression that this got dead because Microsoft is unwilling to add an open-source license dependency? Minimatch is using ISC which is listed on https://spdx.org/licenses/ as one of the most liberal ones.

from vscode-json-languageservice.

aeschli avatar aeschli commented on July 23, 2024

fixed by #93

from vscode-json-languageservice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.