use real glob instead of simpleRegex about vscode-json-languageservice HOT 6 CLOSED

hello! i'm new here. it turned out that the vscode-common repo doesn't actually have glob.ts in it. i implemented a solution to this with the vscode-anymatch package, which is just a fork of anymatch, but since it's a dependency for vscode-chokidar, i assume it's ok to use.

i also wrote some additional tests to make sure it works as expected, presuming that fileMatch is intended to be glob patterns.

i went ahead and submitted a pull request, but do feel free to do whatever you'd like!

from vscode-json-languageservice.

Sorry, I'm just swamped with other priorities. I'm not against the suggested changes, the node_module dependency is not a problem, just causes extra administrative work for which I didn't have had time yet.

from vscode-json-languageservice.

As written in the API comment, currently we only support '*', not glob
I'm not opposed to allow glob as well but ideally implement it ourselves inside json-languageservice so I don't need to spend any time with legal approvals.

from vscode-json-languageservice.

Understandable. Maybe we can use this code: https://github.com/microsoft/vscode/blob/master/src/vs/base/common/glob.ts?

Not sure tough how to integrate this code into into this library.

I realized that allowing glob pattern (obviously) is a breaking change, so probably we need to provide an alternative option in addition to fileMatch.

from vscode-json-languageservice.

Do we have any chance to get a some progress on this? Currently due to the very limited implementation it is impossible to correctly select schemas for some real world use-cases.

I am wondering it would be ok to just assume that **/ -> .* and * -> [^\/]*. Two stars should cross directory boundaries but one star should only match anything but the directory separator.

Do i have the impression that this got dead because Microsoft is unwilling to add an open-source license dependency? Minimatch is using ISC which is listed on https://spdx.org/licenses/ as one of the most liberal ones.

from vscode-json-languageservice.

fixed by #93

from vscode-json-languageservice.