Synchronous validation about vscode-json-languageservice HOT 9 OPEN

Thanks @azeemba, you are correct, there's a bug. I fixed it with a72b1c0

from vscode-json-languageservice.

Sure, we can add a second validation API doValidate2 that requires a schema and is sync.

You want to give it a try and make a PR?

from vscode-json-languageservice.

I'll give it a go! Thanks - I just wanted to check something like that could be useful for this library.

from vscode-json-languageservice.

I have worked out a way to do what I want by using https://www.npmjs.com/package/synchronous-promise. This means that your library requires no changes to support my usecase because you already allow using a custom promise constructor.

I'm not going to close this issue, as a cleaner solution would be ideal, although I won't object if you wish to.

from vscode-json-languageservice.

I was looking into implementing this but I found something unexpected so wanted to clarify. It seems that getDiagnostics can be either called with a JSONSchema or a ResolvedSchema.
Since the former doesn't have a .error field, I am not sure how this line isn't erroring out.

Is this an issue? Or should the PR for this maintain this behavior?

from vscode-json-languageservice.

I did look into this and that was what stopped me contributing - I thought there was some really complex infrastructure in place to make that work...

from vscode-json-languageservice.

Is there still demand for this or plans to work on this?

from vscode-json-languageservice.

Yes, so my use case is the following:
We have a monaco editor in which we do JSON validation against a given schema and additionally we want to log the diagnostics somewhere. Since the monaco editor doesn’t support simply reading out the diagnostics, we are forced to actually validate the same string again with vscode-json-languageservice.

Since at that point the schema and json string are already given, I would wish there was a simple synchronous validate(json, schema) and in my naive thinking this could be called by doValidation internally?

from vscode-json-languageservice.

Hi, is there any capacity to look into this issue? If I could receive some guidance I could also try to implement this in a PR.

from vscode-json-languageservice.