[gdk-pixbuf] can't build without tiff, libjpeg and libpng as expected about vcpkg HOT 3 CLOSED

Try #38272.

from vcpkg.

@dg0yt
I did some clean builds but only on my Fedora 38 Linux.

I checked the following variants with your change:

./vcpkg install 'gdk-pixbuf'
./vcpkg install 'gdk-pixbuf[jpeg]'
./vcpkg install 'gdk-pixbuf[tiff]'
./vcpkg install 'gdk-pixbuf[jpeg,tiff]'
./vcpkg install 'gdk-pixbuf[png]'
./vcpkg install 'gdk-pixbuf[png,jpeg]'
./vcpkg install 'gdk-pixbuf[png,tiff]'
./vcpkg install 'gdk-pixbuf[png,jpeg,tiff]'

./vcpkg install 'gdk-pixbuf[core]'
./vcpkg install 'gdk-pixbuf[core,jpeg]'
./vcpkg install 'gdk-pixbuf[core,tiff]' (*)
./vcpkg install 'gdk-pixbuf[core,jpeg,tiff]'
./vcpkg install 'gdk-pixbuf[core,png]'
./vcpkg install 'gdk-pixbuf[core,png,jpeg]'
./vcpkg install 'gdk-pixbuf[core,png,tiff]' (*)
./vcpkg install 'gdk-pixbuf[core,png,jpeg,tiff]'

The two variants marked with an asterisk will still install 'libjpeg'

./vcpkg install 'gdk-pixbuf[core,tiff]' (*)
./vcpkg install 'gdk-pixbuf[core,png,tiff]' (*)

Is this intended? It should be possible to disable 'jpeg' when building with 'tiff'
This is suggested when checking the 'libtiff' upstream configure script.

I wonder if the only solution for these cases is to add an additional 'tiff[core]' to the 'gdk-pixbuf' install commands, which indeed works.

FYI. I didn't check the 'windows' builds

• ae3mdot

P.S.
The 'only' viable option for the comment button below is 'close with comment' ??

from vcpkg.

The two variants marked with an asterisk will still install 'libjpeg'

./vcpkg install 'gdk-pixbuf[core,tiff]' (*)
./vcpkg install 'gdk-pixbuf[core,png,tiff]' (*)

Is this intended? It should be possible to disable 'jpeg' when building with 'tiff'

Yes. You only ask for gdk-pixbuf without direct jpeg capabilities, and you get it.

However, tiff has a [jpeg] feature which is on by default. To disable the use of JPEG compression inside TIFF files, you would need to use:

./vcpkg install 'gdk-pixbuf[core,tiff]' 'tiff[core,<your-desired-features>]'
./vcpkg install 'gdk-pixbuf[core,png,tiff]' 'tiff[core,<your-desired-features>]'

This is suggested when checking the 'libtiff' upstream configure script.

There is not much relevance in the upstream configure script. We build with CMake.
https://gitlab.com/libtiff/libtiff/-/blob/master/cmake/JPEGCodec.cmake?ref_type=heads

And libtiff without jpeg would be quite incomplete. There is some "old" JPEG support which is off by default in both buildsystems IIUC.

from vcpkg.