Comments (15)
dg0yt
commented on September 26, 2024
1
community triplet.
But identical to x64-windows-static-md which builds pcl in vcpkg CI.
from vcpkg.
dzenanz
commented on September 26, 2024
1
I opened a draft PR: PointCloudLibrary/pcl#5985.
from vcpkg.
dg0yt
commented on September 26, 2024
1
Should be fixed now with #37785 merged.
from vcpkg.
dzenanz
commented on September 26, 2024
1
With fbc542f, the build succeeds:
C:\Libs\vcpkg>vcpkg install pcl[vtk,apps,visualization]
Computing installation plan...
The following packages will be built and installed:
pcl[apps,core,opengl,openni2,qt,visualization,vtk]:[email protected]#3
Detecting compiler hash for triplet x64-windows-my...
Compiler found: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.39.33519/bin/Hostx64/x64/cl.exe
Restored 0 package(s) from C:\Users\Dzenan\AppData\Local\vcpkg\archives in 495 us. Use --debug to see more details.
Installing 1/1 pcl[apps,core,opengl,openni2,qt,visualization,vtk]:[email protected]#3...
Building pcl[apps,core,opengl,openni2,qt,visualization,vtk]:[email protected]#3...
-- Using cached PointCloudLibrary-pcl-pcl-1.14.0.tar.gz.
-- Extracting source C:/Libs/vcpkg/downloads/PointCloudLibrary-pcl-pcl-1.14.0.tar.gz
-- Applying patch add-gcc-version-check.patch
-- Applying patch fix-check-sse.patch
-- Applying patch fix-numeric-literals-flag.patch
-- Applying patch install-layout.patch
-- Applying patch install-examples.patch
-- Applying patch fix-clang-cl.patch
-- Applying patch gh-5926-exports.patch
-- Applying patch gh-5947-kinfu.patch
-- Applying patch gh-5985-inline.patch
-- Applying patch io_ply.patch
-- Using source at C:/Libs/vcpkg/buildtrees/pcl/src/pcl-1.14.0-40680cf035.clean
-- Found external ninja('1.11.0').
-- Configuring x64-windows-my
-- Building x64-windows-my-dbg
-- Building x64-windows-my-rel
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_2d.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_apps.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_common.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_features.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_filters.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_geometry.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_io.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_io_ply.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_kdtree.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_keypoints.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_ml.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_octree.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_outofcore.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_people.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_recognition.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_registration.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_sample_consensus.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_search.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_segmentation.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_stereo.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_surface.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_tracking.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/lib/pkgconfig/pcl_visualization.pc
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.1.0-1-any.pkg.tar.zst.
-- Using cached msys2-msys2-runtime-3.4.10-4-x86_64.pkg.tar.zst.
-- Using msys root at C:/Libs/vcpkg/downloads/tools/msys2/fdbea3694fb5c0d4
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_2d.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_common.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_features.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_filters.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_geometry.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_io.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_io_ply.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_kdtree.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_keypoints.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_ml.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_octree.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_outofcore.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_people.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_recognition.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_registration.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_sample_consensus.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_search.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_segmentation.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_stereo.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_surface.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_tracking.pc
-- Fixing pkgconfig file: C:/Libs/vcpkg/packages/pcl_x64-windows-my/debug/lib/pkgconfig/pcl_visualization.pc
-- Installing: C:/Libs/vcpkg/packages/pcl_x64-windows-my/share/pcl/usage
-- Installing: C:/Libs/vcpkg/packages/pcl_x64-windows-my/share/pcl/copyright
-- Performing post-build validation
Stored binaries in 1 destinations in 1.3 min.
Elapsed time to handle pcl:x64-windows-my: 8.6 min
pcl:x64-windows-my package ABI: ee1991ed83659f147ac80a406d1f978f92a1c954442aa88d65c1f8582fd85cc8
Total install time: 8.6 min
The package pcl provides CMake targets:
find_package(PCL CONFIG REQUIRED)
target_link_libraries(main PRIVATE ${PCL_LIBRARIES})
from vcpkg.
JackBoosY
commented on September 26, 2024
community triplet.
from vcpkg.
mvieth
commented on September 26, 2024
I most likely found the problem: there is an inline missing here: https://github.com/PointCloudLibrary/pcl/blob/ad2bf688b2d036fe703cd16ea6d574e453e101b2/segmentation/include/pcl/segmentation/impl/grabcut_segmentation.hpp#L51
If nobody else wants to, I will create a pull request with a fix in a few days.
from vcpkg.
FrankXie05
commented on September 26, 2024
@mvieth Don't worry, I'll fix it. :)
from vcpkg.
dg0yt
commented on September 26, 2024
I do worry.
Please prepare a fix upstream. Than I can pick it easily into the collection of port pcl changes which piles up in #37651.
from vcpkg.
dzenanz
commented on September 26, 2024
I probably created my triplet before x64-windows-static-md existed 😄
from vcpkg.
mvieth
commented on September 26, 2024
@dg0yt I would like to add some more changes to this patch file: https://github.com/microsoft/vcpkg/blob/master/ports/pcl/fix-pcl-exports.patch , so that it is equivalent to this commit on the PCL master branch: PointCloudLibrary/pcl@e9d7131
Would you do that in #37651 as well, or shall I create a pull request after that one is merged?
Related: PointCloudLibrary/pcl#5984
from vcpkg.
dg0yt
commented on September 26, 2024
Hm, is it to fix a bug? The total level of patching is already questionable. (And so are some patches.) A pcl patch release could be a more better starting point.
from vcpkg.
mvieth
commented on September 26, 2024
Hm, is it to fix a bug? The total level of patching is already questionable. (And so are some patches.) A pcl patch release could be a more better starting point.
Yes, it fixes a bug ( PointCloudLibrary/pcl#5984 ). The next PCL release 1.14.1 is indeed not in the too far future, but I thought it would be nice to have this fixed on vcpkg already before that.
from vcpkg.
dg0yt
commented on September 26, 2024
But the port is more and more decoupling from the official release. And every user carries the git repo with the patch history for all ports...
from vcpkg.
mvieth
commented on September 26, 2024
In the end, it is not my decision, and I am okay with it if the patch is not added/extended. Just out of curiosity: is there a vcpkg guideline defining which changes are patch-worthy? New features would obviously not be accepted as patches, but are there specific criteria a bug-fixing patch must meet?
from vcpkg.
dg0yt
commented on September 26, 2024
(I picked the change already in parallel.)
IDK if there are (or can be) guidelines for the exact border. Basically, patches shall be the exception, and upstream bugs shall be fixed ín upstream releases...
And integrating the ABI-changing bug fix here isn't really ideal, even if it is tracked properly within the vcpkg universe.
from vcpkg.
Related Issues (20)
- Allow vcpkg executable outside of VCPKG_ROOT when using scripts/buildsystems/vcpkg.cmake
- [New Port Request] <LunaSVG> HOT 1
- [qtimageformats] 6.5.3#0 can't load jpeg and webp HOT 4
- [openssl] incorrect CMake config (patch) HOT 8
- [magma] Build error on x64-windows HOT 1
- [magma] Build error on x64-windows HOT 2
- Boost libraries do not seem to respect VCPKG_PLATFORM_TOOLSET
- [boost-stacktrace] Build failure on x64-windows HOT 1
- [boost] build failure on x64-windows
- Visual studio integration fails to rebuild dependencies on compiler version change HOT 3
- [shiftmedia-libgnutls] build failure HOT 1
- [libnoise] Build failure on x64-linux HOT 8
- [zlib] Build error on x86-windows (issue downloading libraries from github?) HOT 2
- [czmq] Build failure on x64-mingw-dynamic
- [avro-cpp] update to 1.12.0
- [vcpkg-ci-crashpad] CI build failure
- [sassc] Build error on x64-mingw-dynamic HOT 1
- [openmesh] Build error on x64-mingw-dynamic HOT 1
- [glog] Build error on x64-windows-vs2015 HOT 4
- [jsoncpp] Build error on x64-linux HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vcpkg.