Git Product home page Git Product logo

Comments (2)

blickly avatar blickly commented on May 20, 2024

I've started taking a look at this, and after figuring out how to repro in fourslash, it looks like there is a crash coming from pretty deep within a call to ChangeTracker.getChanges

  1) fourslash tests
       tests/cases/fourslash/codeFixMissingTypeAnnotationOnExports47-tsx-with-dash.tsx
         fourslash test codeFixMissingTypeAnnotationOnExports47-tsx-with-dash.tsx runs correctly:
     Error: Debug Failure. False expression: Token end is child end
      at processChildNode (src/services/formatting/formatting.ts:880:27)
      at /Users/blickly/repos/TypeScript/src/services/formatting/formatting.ts:791:17
      at visitNode (src/compiler/parser.ts:441:20)
      at forEachChildInJsxAttribute (src/compiler/parser.ts:1022:16)
      at forEachChild (src/compiler/parser.ts:1251:43)
      at processNode (src/services/formatting/formatting.ts:788:9)
      at processChildNode (src/services/formatting/formatting.ts:889:13)
      at processChildNodes (src/services/formatting/formatting.ts:955:40)
      at /Users/blickly/repos/TypeScript/src/services/formatting/formatting.ts:794:17
      at visitNodes (src/compiler/parser.ts:447:20)
      at forEachChildInJsxAttributes (src/compiler/parser.ts:1019:16)
      at forEachChild (src/compiler/parser.ts:1251:43)
      at processNode (src/services/formatting/formatting.ts:788:9)
      at processChildNode (src/services/formatting/formatting.ts:889:13)
      at /Users/blickly/repos/TypeScript/src/services/formatting/formatting.ts:791:17
      at visitNode (src/compiler/parser.ts:441:20)
      at forEachChildInJsxOpeningOrSelfClosingElement (src/compiler/parser.ts:1191:9)
      at forEachChild (src/compiler/parser.ts:1251:43)
      at processNode (src/services/formatting/formatting.ts:788:9)
      at processChildNode (src/services/formatting/formatting.ts:889:13)
      at /Users/blickly/repos/TypeScript/src/services/formatting/formatting.ts:791:17
      at visitNode (src/compiler/parser.ts:441:20)
      at forEachChildInParenthesizedExpression (src/compiler/parser.ts:756:16)
      at forEachChild (src/compiler/parser.ts:1251:43)
      at processNode (src/services/formatting/formatting.ts:788:9)
      at processChildNode (src/services/formatting/formatting.ts:889:13)
      at /Users/blickly/repos/TypeScript/src/services/formatting/formatting.ts:791:17
      at visitNode (src/compiler/parser.ts:441:20)
      at forEachChildInSatisfiesExpression (src/compiler/parser.ts:793:16)
      at forEachChild (src/compiler/parser.ts:1251:43)
      at processNode (src/services/formatting/formatting.ts:788:9)
      at processChildNode (src/services/formatting/formatting.ts:889:13)
      at /Users/blickly/repos/TypeScript/src/services/formatting/formatting.ts:791:17
      at visitNode (src/compiler/parser.ts:441:20)
      at forEachChildInAsExpression (src/compiler/parser.ts:786:16)
      at forEachChild (src/compiler/parser.ts:1251:43)
      at processNode (src/services/formatting/formatting.ts:788:9)
      at formatSpanWorker (src/services/formatting/formatting.ts:521:9)
      at /Users/blickly/repos/TypeScript/src/services/formatting/formatting.ts:440:9
      at getFormattingScanner (src/services/formatting/formattingScanner.ts:69:17)
      at Object.formatNodeGivenIndentation (src/services/formatting/formatting.ts:439:12)
      at getFormattedTextOfNode (src/services/textChanges.ts:1342:36)
      at format (src/services/textChanges.ts:1313:37)
      at computeNewText (src/services/textChanges.ts:1316:15)
      at /Users/blickly/repos/TypeScript/src/services/textChanges.ts:1278:33
      at mapDefined (src/compiler/core.ts:518:28)
      at /Users/blickly/repos/TypeScript/src/services/textChanges.ts:1273:33
      at mapDefined (src/compiler/core.ts:518:28)
      at Object.getTextChangesFromChanges (src/services/textChanges.ts:1263:16)
      at _ChangeTracker.getChanges (src/services/textChanges.ts:1179:39)
      at withContext (src/services/codefixes/fixMissingTypeAnnotationOnExports.ts:254:36)

After debugging a bit, I suspect the issue is that the formatter seems to rely on Nodes having a valid parent pointer (such as here), which seem to be set to undefined in the replacement node passed to the ChangeTracker.

Is it safe to assume that the ChangeTracker / formatter in TS are designed to require valid parent pointers?

from typescript.

jakebailey avatar jakebailey commented on May 20, 2024

Judging by the location, this looks more like that the formatter didn't consider - to be a part of a name; it checks if it's a token (which I'm assuming is -), then only complains if that's in JsxText, but surely it can be an attribute too.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.