Comments (7)
@RyanCavanaugh Is this not worth patching into TS 5.5?
Given how easy this is to repro, I'd assume this would occur often in the wild.
Issues like this that are only exposed in build output are also particularly insidious because most library authors don't explicitly check their build output, and most consumers use skipLibCheck
, which would result in the affected type silently resolving to any
.
from typescript.
Yeah, good points all around
from typescript.
Given that this was introduced before release wouldn't it be a better strategy to revert the commit that introduced the bug and defer that commit to 5.6? It feels a bit odd to introduce a bug, recognize that it is a bug and defer the fix till a further version. I would understand the choice if this didn't came up pre-release
from typescript.
Bisects to #57772
from typescript.
This would be quite a disaster especially considering this only occurs in the .d.ts which for libraries are often generated just before publishing.
from typescript.
Following as Effect may be affected
from typescript.
Hmm this matches a ton of common behavior, even the humble as const
"enum" is affected.
export const Color = {
Red: "Red",
Green: "Green",
Blue: "Blue"
} as const
export type Color = typeof Color
export type Colors = Color[keyof Color]
This being broked^
though this works fine:
export const Color = {
Red: "Red",
Green: "Green",
Blue: "Blue"
} as const
export type Color = typeof Color[keyof typeof Color]
hmmmm
from typescript.
Related Issues (20)
- Function returning a key with type never can be assigned to a typed Object HOT 11
- ++(^^{free v bucks generator 2024 free vbucks codes List updated May {{NewW}}
- ++(^^{free v bucks generator 2024 free vbucks codes List updated May {{New++}}
- ++(^^{free v bucks generator 2024 free vbucks codes List updated May {{UPDATE}}
- ++(^^{free v bucks generator 2024 free vbucks codes List updated May {{UPDATE_NEW}}
- ++(^^{free v bucks generator 2024 free vbucks codes List updated May {{UPDATE_NOW}}
- TypeScript imports createElement factory function when using jsx=react-jsx HOT 1
- When using react-jsx, don't treat "key" property as special unless it's specified as IntrinsicAttribute HOT 4
- [NewErrors] 5.5.0-dev.20240519 vs 5.4.5 HOT 59
- [ServerErrors][TypeScript] undefined HOT 4
- Optional parameters instantiated from generic params add `| undefined` to the type HOT 9
- [ServerErrors][JavaScript] 5.5.0-dev.20240519 HOT 3
- Function parameters are not inferable when defined via JSDoc using @type tag (with strict) HOT 5
- Reachability analysis of `never` for `yield*` is unchecked HOT 1
- Declaration emit not dropping untyped computed property name
- `getTextOfJSDocComment` introduces a space in JSDoc comments
- Typescript Stickers HOT 5
- Bloomberg TS5.5-beta feedback [part two]
- FEATURE REQUEST: For TypeScript / JS add new refactor feature: if class method can be static add tooltip "make method static" HOT 2
- Incorrect type handing/reduction HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.